Skip to content

[UIK-5551] pills rebranding#3060

Open
slizhevskyv-semrush wants to merge 17 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5551/pills-rebranding
Open

[UIK-5551] pills rebranding#3060
slizhevskyv-semrush wants to merge 17 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5551/pills-rebranding

Conversation

@slizhevskyv-semrush

@slizhevskyv-semrush slizhevskyv-semrush commented Jul 21, 2026 •
edited by ilyabrower
Loading

Copy link
Copy Markdown
Contributor

Motivation and Context

Pills rebranding.

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@slizhevskyv-semrush
slizhevskyv-semrush changed the base branch from release/v17 to UIK-5351/add-more-variables-to-theme July 21, 2026 09:53
ilyabrower
ilyabrower reviewed Jul 21, 2026
View reviewed changes
Comment thread semcore/pills/src/style/pills.shadow.css Outdated
Comment thread semcore/pills/src/style/pills.shadow.css Outdated
Comment thread semcore/pills/src/style/pills.shadow.css Outdated
}
SPillSeparator {
width: 1px;
height: 18px;

@ilyabrower ilyabrower Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think to use here something likecalc(var(--intergalactic-form-control-m) - var(border?) - var(padding) ?

@slizhevskyv-semrush slizhevskyv-semrush Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I get an idea correctly, the separator size should be equal to text's height...
but I don't have any ideas how to achieve this in a simple way....

@sheila-semrush sheila-semrush Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, I think we can try just lh-200 (300 in size L), so that it equals the line height. It's a bit different to the design, but we will look at it live and maybe it'll be fine

@slizhevskyv-semrush slizhevskyv-semrush Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheila-semrush could you please verify it during Desing Review phase and leave it if it will make sense?

@sheila-semrush sheila-semrush Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up making them just spacing-4x/6x
we'll also synchronize them with filter trigger after both are merge (I added a reminder to our root task)

Comment thread semcore/pills/src/style/pills.shadow.css Outdated
margin-right: var(--intergalactic-spacing-3x, 12px);
}
&[size='l'] {
height: 24px;

@ilyabrower ilyabrower Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Comment thread semcore/pills/src/Pills.tsx Outdated
Comment thread semcore/pills/src/Pills.tsx Outdated
Comment thread semcore/pills/src/Pills.tsx
Comment thread semcore/pills/package.json
ilyabrower
ilyabrower reviewed Jul 21, 2026
View reviewed changes
Comment thread semcore/pills/src/Pills.tsx Outdated
Comment thread semcore/pills/src/Pills.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabrower ilyabrower ilyabrower left review comments
@sheila-semrush sheila-semrush sheila-semrush left review comments
@Valeria-Zimnitskaya Valeria-Zimnitskaya Awaiting requested review from Valeria-Zimnitskaya

Assignees

No one assigned

Labels

feature-highlight pills

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slizhevskyv-semrush @ilyabrower @sheila-semrush @j-mnizhek