Canonical onboarding funnel followup

[shazarre]

Linear: SELF-2746

Summary

A brief follow up for ANA-01 plan:

• adding a missed diagnostic event
• more test coverage
• updating the spec itself

Test plan

Covered by unit tests + confirmed the new diagnostic event being fired:

Summary by CodeRabbit

• Tests

  • Added test coverage for canonical onboarding event names and validation.
  • Added tests for registration proof flag behavior in the proving machine.

• Documentation

  • Updated onboarding funnel analytics plan status.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
self-webview-app	Ignored	Preview	Apr 29, 2026 10:22am

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3554e196-7ed9-4b7e-b883-2b99bd2adfef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This pull request adds analytics event tracking for a belonging confirmation workflow. It introduces a new DiagnosticEvents analytics event constant, emits the CONFIRM_BELONGING_CONFIRMED event after successful notification permission grant, and includes test coverage for analytics event naming and proving machine state transitions.

Changes

Cohort / File(s)	Summary
Analytics Event Definition packages/mobile-sdk-alpha/src/constants/analytics.ts	Adds new DiagnosticEvents export containing CONFIRM_BELONGING_CONFIRMED event key mapped to 'confirm_belonging_confirmed'.
Screen Implementation app/src/screens/documents/selection/ConfirmBelongingScreen.tsx	Imports DiagnosticEvents and emits CONFIRM_BELONGING_CONFIRMED analytics event in onOkPress after successful notification permission grant.
Test Coverage packages/mobile-sdk-alpha/tests/analytics/canonicalEvents.test.ts, packages/mobile-sdk-alpha/tests/proving/provingMachine.analytics.test.ts	Adds test suite for OnboardingEvents canonical event naming (29 lines) and new provingMachine.analytics test file validating didNewRegistrationProof flag behavior across circuit types and initialization scenarios (143 lines).
Documentation specs/projects/sdk/workstreams/analytics/plans/ANA-01-canonical-onboarding-funnel.md	Updates metadata: advances Last updated date to 2026-04-29 and marks Status as Done.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Canonical onboarding funnel followup' accurately describes the PR's main objective—a followup to the ANA-01 canonical onboarding plan that adds a diagnostic event, increases test coverage, and updates the spec.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch shazarre/canonical_onboarding_funnel_followup

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shazarre]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cb280928-9655-4e92-8d4b-ae08c07a1915

📥 Commits

Reviewing files that changed from the base of the PR and between e19aeb0 and fba53cc.

📒 Files selected for processing (5)

• app/src/screens/documents/selection/ConfirmBelongingScreen.tsx
• packages/mobile-sdk-alpha/src/constants/analytics.ts
• packages/mobile-sdk-alpha/tests/analytics/canonicalEvents.test.ts
• packages/mobile-sdk-alpha/tests/proving/provingMachine.analytics.test.ts
• specs/projects/sdk/workstreams/analytics/plans/ANA-01-canonical-onboarding-funnel.md

[transphorm]

Targeting this for the next build: 2.9.23. Tracked in the Mobile App release: 2.9.23 project.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.