Fix disclosure proof button text not centered - #1912
Conversation
Remove flex: 1 from AbstractButton text style so content is centered by the container's justifyContent instead of relying on textAlign within a stretched element. The old approach failed when children were View components (e.g. LoadingContent with ActivityIndicator) since textAlign only affects text, not nested Views.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
flex: 1fromAbstractButtontext style so content is centered by the container'sjustifyContentinstead of relying ontextAlignwithin a stretched elementLoadingContentwithActivityIndicator) sincetextAlignonly affects text, not nested ViewsTest plan
Summary by CodeRabbit