Skip to content

Fix disclosure proof button text not centered - #1912

Open
Tranquil-Flow wants to merge 1 commit into
devfrom
fix/disclosure-button-text-centering
Open

Fix disclosure proof button text not centered#1912
Tranquil-Flow wants to merge 1 commit into
devfrom
fix/disclosure-button-text-centering

Conversation

@Tranquil-Flow

@Tranquil-Flow Tranquil-Flow commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove flex: 1 from AbstractButton text style so content is centered by the container's justifyContent instead of relying on textAlign within a stretched element
  • The old approach failed when children were View components (e.g. LoadingContent with ActivityIndicator) since textAlign only affects text, not nested Views
  • Affects the disclosure proof flow bottom button across all its states (loading, preparing, ready)

Test plan

  • Open disclosure proof flow on device
  • Verify button text is centered in all states: "Waiting for app...", "Accessing Keychain data", "Parsing passport data", "Preparing for verification", "Press and hold to verify", "Generating proof"
  • Verify other buttons throughout the app remain visually correct (settings, onboarding, etc.)

Summary by CodeRabbit

  • Style
    • Refined button text layout behavior in mobile SDK components to improve visual presentation and consistency.

Remove flex: 1 from AbstractButton text style so content is centered by the container's justifyContent instead of relying on textAlign within a stretched element. The old approach failed when children were View components (e.g. LoadingContent with ActivityIndicator) since textAlign only affects text, not nested Views.
@vercel

vercel Bot commented Apr 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
self-webview-app Ready Ready Preview, Comment Apr 2, 2026 5:23am

Request Review

@coderabbitai

coderabbitai Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d121e3d-d7be-40af-9209-b746b852bad7

📥 Commits

Reviewing files that changed from the base of the PR and between 5124af9 and 53466c4.

📒 Files selected for processing (1)
  • packages/mobile-sdk-alpha/src/components/buttons/AbstractButton.tsx
💤 Files with no reviewable changes (1)
  • packages/mobile-sdk-alpha/src/components/buttons/AbstractButton.tsx

📝 Walkthrough

Walkthrough

Removed the flex: 1 CSS property from the text style definition in the AbstractButton component. This single-line modification alters the text element's layout behavior within the button's Pressable container.

Changes

Cohort / File(s) Summary
Button Styling
packages/mobile-sdk-alpha/src/components/buttons/AbstractButton.tsx
Removed flex: 1 style rule from text style definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix disclosure proof button text not centered' directly reflects the main change: removing flex: 1 from AbstractButton text style to fix text centering.
Description check ✅ Passed The description includes a clear summary of changes and a comprehensive test plan, covering all required information about the fix and verification steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/disclosure-button-text-centering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant