fix: add placeholder for pages with no contributors - #594
Open
frameworks-volunteer wants to merge 2 commits into
Open
fix: add placeholder for pages with no contributors#594frameworks-volunteer wants to merge 2 commits into
frameworks-volunteer wants to merge 2 commits into
Conversation
…ecurity-alliance#593) When a page has contributor roles defined but all user lists are empty, the AttributionList component rendered an empty styled container with no content. Now displays a "No contributors yet" placeholder with a link to the contributing guide, improving UI/UX for new or unstewarded pages.
5 tasks
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
frameworks-volunteer
left a comment
frameworks-volunteer
left a comment
Collaborator
Author
There was a problem hiding this comment.
Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter
Security + QA review complete. Leaving a comment review (cannot approve own PR).
Security
- No secrets, tokens, or API keys introduced.
- Placeholder text is static; no user input rendered — no XSS/injection surface.
- No unsafe eval, deserialization, or new dependencies.
- The
<a href="/contribute/contributing">is a relative internal path validated against existing docs usage. No arbitrary-URL risk.
QA
- Changes match the PR description and linked issue #593:
hasAnyContributor()helper + placeholder JSX + CSS. /contribute/contributinglink resolves todocs/pages/contribute/contributing.mdx— confirmed valid via repo-wide search.- No frontmatter changes (component-only PR, so contributor attribution rule N/A).
- CI all green: build preview, lint, socket security, sidebar-reminder.
- No leftover debug content, TODOs, or placeholder cruft.
- CSS follows the existing dark/light theme pattern consistently with surrounding rules.
hasAnyContributor()correctly mirrors the existingRoleSectionnull-filtering logic.
No blockers. Ready to merge.
…he frontmatter is present + substitute <a> tag with <Link> to do not trigger a reload
scode2277
approved these changes
Aug 6, 2026
scode2277
left a comment
scode2277
left a comment
Collaborator
There was a problem hiding this comment.
I've made two changes:
- the "no contributors" message now shows on any page that has nobody to credit. Before, it only appeared when the frontmatter had a
contributors:block with emptyusers:lists. To be extra safe, I made it that also pages with nocontributors:block render it. - I substituted the
<a>tag with the<Link>one so the click doesn't trigger a reload of the page
gtg for me @mattaereal. Check it out at -> https://595656a7.frameworks-573.pages.dev/privacy/overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users: []), theAttributionListcomponent rendered an empty styled container with no visible content.hasAnyContributor()helper to detect the all-empty state before rendering role sections.Changes
components/attribution/AttributionList.tsx— newhasAnyContributor()check + placeholder JSXcomponents/attribution/AttributionList.css—.attribution-empty,.attribution-placeholder,.attribution-placeholder-linkstylesCloses #593