fix: make the banner wrap line on mobile - #560
Open
scode2277 wants to merge 4 commits into
Open
Conversation
frameworks-volunteer
approved these changes
Jul 20, 2026
frameworks-volunteer
left a comment
frameworks-volunteer
left a comment
Collaborator
There was a problem hiding this comment.
Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter
Security + QA review complete.
Security: No concerns. Pure CSS change, no secrets, no injection vectors, no unsafe patterns.
QA:
- Changes match PR description (banner wrapping on mobile/narrow screens)
- CI passes: lint, socket security, Cloudflare Pages all green
- No frontmatter or link issues (CSS-only file)
Minor suggestion (non-blocking): there is already a [data-v-banner-content] block at line 54 (font-style: italic). The new properties could be merged into that existing block instead of adding a second block for the same selector. Not blocking.
LGTM — approving.
Deploying frameworks with
|
| Latest commit: |
c6cb637
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c9e8665.frameworks-573.pages.dev |
| Branch Preview URL: | https://fix-banner-workaround.frameworks-573.pages.dev |
…y added workaroud + adjusted head property in vocs.config file as the bump changed the configuration of it
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
I've added a workaround for the banner to wrap line when on mobile or narrower screens as well as opened an issue on vocs' repo
Update: Vocs' has fixed the issue, so I bumped vocs' version and removed the workaround + I fixed the head property in the vocs.config.ts file as the bump required different configuration of it
Type of change
If applicable
vocs.config.tswith thedev: trueparameterStuck on anything? Just write it here and we're happy to help.