fix: derive marketplace skill count - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instead of pinning the former 15-skill inventory
packaged skills still fail the release
Root cause
The immutable v5.1.0 package correctly contains 17 skills. Its release workflow
reached the post-publish marketplace lifecycle, then failed because
qa/plugin-marketplace-e2e.shstill compared the installed count with the staleliteral
15. The failure was in the release assertion, not plugin installationor npm packaging.
User and release impact
The marketplace E2E now compares the installed npm plugin with the tagged source
inventory. This corrective patch does not weaken the packaging check and does
not rewrite the already-published v5.1.0 artifacts.
Validation
npm run spec:checkshellcheck -S warning qa/plugin-marketplace-e2e.shbash qa/conformance-eval.sh --validate: 17/17npm run check: exit 0, including 383/383 hook smoke cases, Phase 4,ShellCheck, and the 24-surface live-home guard
pass:true,inconclusive:falsenpm pack --dry-run --json:@sdsrs/agentsmd@5.1.1, 137 entriesThe hosted real-model scenarios remain explicitly unverified because
OPENAI_API_KEYis not configured; no workflow or support threshold wasweakened.