Skip to content

feat: Reposition emoji key, add settings cog, and implement long-press tooltip options#659

Open
Roniscend wants to merge 1 commit into
scribe-org:mainfrom
Roniscend:feature-emoji
Open

feat: Reposition emoji key, add settings cog, and implement long-press tooltip options#659
Roniscend wants to merge 1 commit into
scribe-org:mainfrom
Roniscend:feature-emoji

Conversation

@Roniscend

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

Moves the emoji key between the comma and spacebar, displays a settings cog overlay in its top-right corner, and implements a long-press tooltip containing shortcuts to the floating keyboard, emoji palette, and clipboard.
Fixes: #655

Copilot AI review requested due to automatic review settings July 22, 2026 20:18
@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the emoji key UX by adding a settings-cog overlay, introducing a long-press tooltip popup with shortcuts (emoji + clipboard, with floating keyboard placeholder), and attempting to reposition the emoji key in the bottom row to match the desired layout.

Changes:

  • Add a new long-press popup layout for the emoji key and supporting string resources.
  • Draw a settings-cog overlay on the emoji key during keyboard rendering.
  • Modify keyboard row post-processing logic intended to reposition the emoji key.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Adds new strings for popup accessibility labels (clipboard/floating keyboard).
app/src/main/res/layout/emoji_key_long_hold_popup.xml New tooltip popup UI shown on emoji long-press with three ImageButton options.
app/src/main/res/drawable/ic_settings_cog_vector.xml Replaces an empty selector with an actual vector drawable for the cog overlay.
app/src/main/java/be/scri/views/KeyboardView.kt Draws cog overlay on emoji key and shows a PopupWindow tooltip on emoji long-press.
app/src/main/java/be/scri/helpers/KeyboardBase.kt Updates bottom-row key adjustment logic intended to place emoji between comma and space.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/main/java/be/scri/helpers/KeyboardBase.kt Outdated
Comment thread app/src/main/res/values/strings.xml
Comment thread app/src/main/res/layout/emoji_key_long_hold_popup.xml
Comment thread app/src/main/res/layout/emoji_key_long_hold_popup.xml
Comment thread app/src/main/res/layout/emoji_key_long_hold_popup.xml
Comment thread app/src/main/java/be/scri/views/KeyboardView.kt Outdated
Comment thread app/src/main/java/be/scri/views/KeyboardView.kt Outdated
Comment thread app/src/main/java/be/scri/views/KeyboardView.kt Outdated
@andrewtavis

Copy link
Copy Markdown
Member

All's looking good here, @Roniscend! A few points:

  • Can we fix the icon on the emoji key as it's off the key now
Screenshot 2026-07-23 at 01 09 58 (Pixel 9)
  • What are we doing for the clipboard key on the 123 keys? Are we leaving it or removing it? If we leave it, it should likely be between the comma and space bar for consistency. (feel free to make this change if we're keeping it)
  • For the long hold option, we're not allowing the user to slide for an option as we do with alternate characters keys?

I'll take another look after the next commits!

@andrewtavis

Copy link
Copy Markdown
Member

@angrezichatterbox, checking in with you as well: Do we want this to be a slide as well? And what are your opinions on the clipboard key on the 123 keys?

@angrezichatterbox

Copy link
Copy Markdown
Member

Will bring this PR in and check how it looks tonight

@Roniscend
Roniscend force-pushed the feature-emoji branch 2 times, most recently from 1bd3619 to 5f32282 Compare July 23, 2026 14:31
@andrewtavis

Copy link
Copy Markdown
Member

Let us know if we're ready for further review here, @Roniscend :) Thanks for the further commits!

@Roniscend

Copy link
Copy Markdown
Collaborator Author

Let us know if we're ready for further review here, @Roniscend :) Thanks for the further commits!

I have made some changes please review them

@angrezichatterbox

Copy link
Copy Markdown
Member

@angrezichatterbox, checking in with you as well: Do we want this to be a slide as well? And what are your opinions on the clipboard key on the 123 keys?

I am fine with the clipboard key on 123 but I'm not sure if thats a good pattern to follow as it feels like a easter egg. Can we have a similar implementation to Gboard if possible on the force touch so that it feels more elegant. The alternate keys in this case could be more centered. This is what I felt @andrewtavis. The current implementation is good enough but it wouldn't be easily visible to the user.

@andrewtavis

Copy link
Copy Markdown
Member

Let's get these improvements in so that merging this finalizes this then 😊 Thanks for the review, @angrezichatterbox!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow keyboard special settings on emoji long hold and move key

4 participants