feat: Reposition emoji key, add settings cog, and implement long-press tooltip options#659
feat: Reposition emoji key, add settings cog, and implement long-press tooltip options#659Roniscend wants to merge 1 commit into
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
Pull request overview
This PR updates the emoji key UX by adding a settings-cog overlay, introducing a long-press tooltip popup with shortcuts (emoji + clipboard, with floating keyboard placeholder), and attempting to reposition the emoji key in the bottom row to match the desired layout.
Changes:
- Add a new long-press popup layout for the emoji key and supporting string resources.
- Draw a settings-cog overlay on the emoji key during keyboard rendering.
- Modify keyboard row post-processing logic intended to reposition the emoji key.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds new strings for popup accessibility labels (clipboard/floating keyboard). |
| app/src/main/res/layout/emoji_key_long_hold_popup.xml | New tooltip popup UI shown on emoji long-press with three ImageButton options. |
| app/src/main/res/drawable/ic_settings_cog_vector.xml | Replaces an empty selector with an actual vector drawable for the cog overlay. |
| app/src/main/java/be/scri/views/KeyboardView.kt | Draws cog overlay on emoji key and shows a PopupWindow tooltip on emoji long-press. |
| app/src/main/java/be/scri/helpers/KeyboardBase.kt | Updates bottom-row key adjustment logic intended to place emoji between comma and space. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
All's looking good here, @Roniscend! A few points:
I'll take another look after the next commits! |
|
@angrezichatterbox, checking in with you as well: Do we want this to be a slide as well? And what are your opinions on the clipboard key on the 123 keys? |
|
Will bring this PR in and check how it looks tonight |
1bd3619 to
5f32282
Compare
|
Let us know if we're ready for further review here, @Roniscend :) Thanks for the further commits! |
I have made some changes please review them |
I am fine with the clipboard key on 123 but I'm not sure if thats a good pattern to follow as it feels like a easter egg. Can we have a similar implementation to Gboard if possible on the force touch so that it feels more elegant. The alternate keys in this case could be more centered. This is what I felt @andrewtavis. The current implementation is good enough but it wouldn't be easily visible to the user. |
|
Let's get these improvements in so that merging this finalizes this then 😊 Thanks for the review, @angrezichatterbox! |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Moves the emoji key between the comma and spacebar, displays a settings cog overlay in its top-right corner, and implements a long-press tooltip containing shortcuts to the floating keyboard, emoji palette, and clipboard.
Fixes: #655