fix(gate): harden reviewer contract diagnostics - #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The reviewer-result contract rejected invalid blocking combinations through a generic finding-contract failure, which made remediation unnecessarily opaque. The first field-level diagnostics also reflected reviewer-controlled JSON values through raw
tostring, leaving a terminal/log control-character injection path, while the new origin-specific branch lacked direct regression coverage.Impact
Malformed reviewer artifacts now fail closed with actionable field-level diagnostics. Every reflected reviewer value is JSON-escaped before reaching stderr, so control characters remain inert. Valid reviewer results and the existing verifier/fallback ownership boundary are unchanged.
Validation
bash tests/shell/test-pr-gate.sh --filter reviewer-protocol— 16 passed, 0 failedtests/bin/run-tests.sh --base main— 8 passed, 0 failed, 0 skippedtests/bin/run-all-tests.sh— 97 passed, 0 failed, 0 skipped