contributing: name the modules the build has - #1171
Draft
kitbellew wants to merge 1 commit into
Draft
Conversation
The walkthrough sent a reader to `testsJVM` and `tests-sources`, and the build has neither since it moved to `projectMatrix`. It also named a Scala SDK five patches old. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IntelliJ walkthrough tells a reader to point a run configuration at the
testsJVMmodule instead oftests-sources. The build has had neither since it moved toprojectMatrix: the test modules are one per row,tests2_12andtests2_13.The screenshots that went with that step, and with the Scala SDK step, are from 2020 and show an IntelliJ that no longer looks like that, so they go with the steps.
I left the
PlatformCompatandBuildInfohighlighting note alone. It may well be stale too, now that the import is narrowed to one Scala version, but I could not check it without running IntelliJ.- Claude (on behalf of Albert)