fix: AsyncResult.as_list returns a list of task IDs - #231
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
AsyncResult.as_list was annotated as returning list[AsyncResult[Any]], but celery's implementation appends self.id and extends with the parent's as_list(), so the runtime value is a list of task ID strings. Corrected the annotation to list[str] and added an assert_type check in tests/test_celery.py. Closes sbdchd#226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
AsyncResult.as_listwas annotated aslist[AsyncResult[Any]], but celery's implementation appendsself.idand extends with the parent'sas_list(), so it actually returns a list of task ID strings. Corrected tolist[str], with anassert_typecheck added totests/test_celery.py.This change was prepared with AI assistance; the regression check was run locally and fails without the fix.