fix: use Firecrawl v2 scrape endpoint in remaining examples - #16
Open
memosr wants to merge 1 commit into
Open
Conversation
Three code examples still called /v1/scrape while the rest of the repo had already migrated to /v2/scrape. Request bodies were already v2-compatible, so only the path changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the skill does
Fixes three code examples that still call the legacy Firecrawl
/v1/scrapeendpoint while the rest of the repo already uses/v2/scrape.Why it's useful
The repo has an inconsistent Firecrawl version across skills:
skills/sapiom-agent-builder/templates/basic-cron.js/v1/scrapeskills/sapiom-agent-builder/references/capabilities.md/v1/scrapeskills/sapiom-deploy/references/patterns.md/v1/scrapeMeanwhile
references/web-scraping.md,references/scraping.mdandtemplates/llm-agent.jsalready use/v2/scrape.Two problems this causes:
sapiom-agent-builder,references/web-scraping.mddocuments/v2/scrapebutreferences/capabilities.mdandtemplates/basic-cron.jsshow/v1/scrape. An agent loading that skill gets conflicting guidance for the same call.basic-cron.jsis a template users copy and deploy. It is running code, not just prose, so the stale path ships into user projects.Firecrawl v2 is the current API and the v2 scrape endpoint is significantly faster thanks to caching. This aligns the stragglers with both upstream Firecrawl and the rest of this repo, and matches the CONTRIBUTING guidance that code examples should work and volatile details should not be left stale.
How you tested it
skills/and confirmed/v1/scrapenow returns zero matches.urlplus optionalformats), so only the path changed. No body, response-shape, or parameter changes were needed. Response access (data.data.markdown,data.data.metadata.title) is unchanged and valid on v2.Not a behaviour change for anything else in the repo.