Security: Prevent OTP identity confusion and account takeover - #1
Open
magqqgq wants to merge 1 commit into
Open
Conversation
This PR fixes a critical vulnerability in the OTP verification flow where the authenticated identity was derived from unverified client-supplied inputs, which allowed potential account takeover attacks. Changes: app/api/auth/verify/route.ts: Removed reliance on the client-supplied email or phone fields for session creation. The authenticated subject is now strictly derived from the verifiedTarget securely returned by the verification provider, ensuring a caller cannot use a valid OTP for one contact to impersonate another victim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical vulnerability in the OTP verification flow where the authenticated identity was derived from unverified client-supplied inputs, which allowed potential account takeover attacks.
Changes:
app/api/auth/verify/route.ts: Removed reliance on the client-supplied email or phone fields for session creation. The authenticated subject is now strictly derived from the verifiedTarget securely returned by the verification provider, ensuring a caller cannot use a valid OTP for one contact to impersonate another victim.