docs: nix package instead of custom fetch - #27
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated Nix snippet uses unquoted attribute access for a hyphenated name (zen-nvim), which will fail to evaluate and should be corrected in the documentation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Nix NVF configuration example in the README to use the nixpkgs-provided zen.nvim plugin package instead of a custom fetchFromGitHub + buildVimPlugin snippet.
Changes:
- Replaces the README’s NVF plugin
packageexample with the nixpkgsvimPluginsentry.
File summaries
| File | Description |
|---|---|
| README.md | Simplifies the NVF Nix example by referencing the nixpkgs vim plugin package rather than an inline fetch/build expression. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.