refactor: serve dev client modules instead of patching the vite client - #152
Open
samrum wants to merge 1 commit into
Open
refactor: serve dev client modules instead of patching the vite client#152samrum wants to merge 1 commit into
samrum wants to merge 1 commit into
Conversation
samrum
commented
Jul 21, 2026
samrum
commented
Owner
- Serve a wrapper module at /@vite/client that re-exports the real vite client (served at /@web-extension/vite-client) and wraps its exported updateStyle / removeStyle to support addStyleTarget style targets, replacing regex patching of the client source
- Give the background service worker a dedicated minimal HMR client that reloads the extension on full-reload and after server restarts, instead of patching document guards and reload calls into the shared client
- Replace DevBuilder watcher.on("change") registrations with the per-environment hotUpdate hook; content css rewrites now use the absolute file path, and additionalInputs html/styles are also rewritten on change
- Replace the client-patching guard test with contract tests: vite client export names, and dev css modules importing style functions from /@vite/client
- Serve a wrapper module at /@vite/client that re-exports the real vite
client (served at /@web-extension/vite-client) and wraps its exported
updateStyle / removeStyle to support addStyleTarget style targets,
replacing regex patching of the client source
- Give the background service worker a dedicated minimal HMR client that
reloads the extension on full-reload and after server restarts, instead
of patching document guards and reload calls into the shared client
- Replace DevBuilder watcher.on("change") registrations with the
per-environment hotUpdate hook; content css rewrites now use the
absolute file path, and additionalInputs html/styles are also rewritten
on change
- Replace the client-patching guard test with contract tests: vite client
export names, and dev css modules importing style functions from
/@vite/client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.