Conversation
- Require Vite ^8.0.0 (Rolldown-based) and Node ^20.19.0 || >=22.12.0 - Move vite from dependencies to peer/dev dependencies - Make the package ESM-only (remove require() entry points) - Import bundler types from vite's Rolldown re-export instead of rollup - Use build.rolldownOptions instead of build.rollupOptions - Compile dev mode content CSS via the Environment API module runner instead of the deprecated ssrLoadModule - Rewrite the vite client patches for the Vite 8 HMR client, restoring service worker reload behavior behind its new hasDocument guards, and add a test that runs the patches against the installed client source - Remove the self.location asset transform (Vite 8 emits import.meta.url) - Only delete + re-emit bundle files when renaming them; Rolldown drops files re-emitted under a deleted fileName - Regenerate test snapshots for Rolldown output BREAKING CHANGE: Vite 8 and Node ^20.19.0 || >=22.12.0 are now required, and the package is ESM-only.
pnpm 11 requires Node >=22.13 to run at all (it uses node:sqlite), so CI's Node 20.x matrix leg failed before installing anything. pnpm 10.34.5 supports Node >=18.12 and works across the full ^20.19.0 || >=22.12.0 range this package targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Vite 8 and Node ^20.19.0 || >=22.12.0 are now required, and the package is ESM-only.