Fix custom provider icons in the model picker and Model Pad - #102
Draft
sambitcreate wants to merge 3 commits into
Draft
Fix custom provider icons in the model picker and Model Pad#102sambitcreate wants to merge 3 commits into
sambitcreate wants to merge 3 commits into
Conversation
Encode saved provider artwork at 1x so the display validator keeps it, recover oversize PNGs on save, theme custom marks like bundled logos, and put the icon on the Model Pad puck. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
Lock the save path to persistable artwork recovery, recover a real 65px PNG, and tighten picker/pad source scans so they cannot match the wrong branch. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
Narrow slug before passing it to ThemedProviderMark so type-check accepts mark as a string. Co-authored-by: Sambit Biswas <sambitcreate@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom provider artwork was saved on retina displays as a 2x PNG (often 128px). The display validator only accepts ≤64px, so
parseProviderdroppedartworkon save. The composer picker and Model Pad never received the icon.This change:
scaleFactor: 1), matching Bot avatars, and fails closed if the PNG still fails the display contractcurrentColormask as bundled logos so they stay visible on dark picker chromeTests cover the 1x encode contract, persist/re-encode of a 65px PNG, the save-path
persistableProviderArtworkwiring, picker entry artwork, themed custom marks, and the pad puck wiring. Electron UI was not driven in this environment; verification is via the focused suites.A Grok 4.6 review found no P0 product bugs. Follow-up commits tighten tests so save recovery cannot regress unnoticed.