PLASMA-7893: changelog 25.02.2026 for sdds-os - #3036
Open
oki1oki wants to merge 2 commits into
Open
Conversation
Contributor
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3036/ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (294)
📒 Files selected for processing (20)
🚧 Files skipped from review as they are similar to previous changes (20)
📝 WalkthroughWalkthroughThe change adds configurable dropdown background tokens in Plasma components and updates SDDS theme mappings for surfaces, borders, hover states, sizes, disabled states, read-only states, and transparent semantic badges. ChangesSurface styling updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
oki1oki
marked this pull request as ready for review
August 11, 2026 12:36
oki1oki
requested review from
TitanKuzmich,
Yakutoc,
Yeti-or,
neretin-trike and
shuga2704
as code owners
August 11, 2026 12:36
github-actions
Bot
requested review from
neretin-trike
and removed request for
TitanKuzmich,
Yakutoc,
Yeti-or,
neretin-trike and
shuga2704
August 11, 2026 12:37
oki1oki
requested review from
IgorYar,
Irinkv and
TitanKuzmich
and removed request for
neretin-trike
August 11, 2026 12:37
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts`:
- Around line 65-69: Update the positive, warning, and negative Autocomplete
view mappings in Autocomplete.config.ts so each sets
tokens.textFieldBorderColorFocus to its matching semantic outline color:
--outline-positive at lines 65-69, --outline-warning at lines 110-114, and
--outline-negative at lines 155-159.
In `@packages/sdds-os/src/components/Select/Select.config.ts`:
- Line 103: Update the Select token mapping for tokens.itemBackgroundHover to
use --surface-solid-card instead of --surface-solid-primary, matching the
default Select view and keeping the dropdown background token unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e4ba6c71-38e6-4b74-be53-a0134cb824d1
⛔ Files ignored due to path filters (294)
cypress/snapshots/os/chromium/Autocomplete/Autocomplete -- afterList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- beforeList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- flip.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- listMaxHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- listWidth.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- renderItem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- view=positive, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- view=warning.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- virtual dynamic height.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Autocomplete/Autocomplete -- virtual.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- afterList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- beforeList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- behavior nesting lists within scroll.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- chipView=accent multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- chipView=default multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- chipView=secondary multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- flip.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- flow async items loading.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- flow, multiple missing value in items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- flow, multiple update label after getting new items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- flow, single update label after getting new items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- listMaxHeight with long list.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- listMaxHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- listWidth.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- renderItem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- renderSelectionIcon.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- selectAll button.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- selectAllSticky.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- shift.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- singleLine=false, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- singleLine=false, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- singleLine=true, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- singleLine=true, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- treeView, arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- treeView, multiple arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- treeView, multiple mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- treeView, single mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- variant.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- view=positive, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- view=warning.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Combobox/Combobox -- virtual.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker dateShortcuts, dateShortcutsPlacement=left, dateShortcutsWidth=5rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker dateShortcuts, dateShortcutsPlacement=right, dateShortcutsWidth=10rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker input date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker select day in popover.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker select month by arrows.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker select month in popover.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker select year by arrows.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- DatePicker select year in popover.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- calendarContainerWidth, calendarContainerHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- case very future date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- controlled datepicker reset date with null.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- controlled datepicker reset date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- default.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- defaultDate, enableContentLeft, enableContentRight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- disabled, readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- input date from calendar.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- input date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- input masked date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- label, leftHelper, placeholder, titleCaption.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- renderFromDate.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- stretch.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- valueError, valueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePicker -- view=default, size=m.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- appearance=clear, firstValueError, secondValueError.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- appearance=clear, firstValueSuccess, secondValueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- appearance=clear, hasClearDivider.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- calendarContainerWidth, calendarContainerHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- controlled datepicker reset date with null.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- controlled datepicker reset date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- dateShortcuts, dateShortcutsPlacement=left, dateShortcutsWidth=5rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- dateShortcuts, dateShortcutsPlacement=right, dateShortcutsWidth=10rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- default.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- defaultDate, enableContent.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- disabled, readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- hintText, required, requiredPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- input date, double calendar.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- input date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- input same date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- label, leftHelper, placeholder, titleCaption.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- renderFromDate.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- stretch.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/DatePicker/DatePickerRange -- valueError, valueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Dropdown/Dropdown -- behavior nesting lists within scroll.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Dropdown/Dropdown -- prop beforeList in items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Dropdown/Dropdown -- prop listWidth.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Dropdown/Dropdown -- prop nested dropdown placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Dropdown/Dropdown -- prop offset.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Dropdown/Dropdown -- prop variant, trigger.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Range/Range -- appearance=clear, firstValueError, secondValueError.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Range/Range -- appearance=clear, firstValueSuccess, secondValueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Range/Range -- appearance=clear, hasClearDivider.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Range/Range -- disabled & readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Range/Range -- error & success.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect selectAllSticky.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect view=default, button-like, isTargetAmount.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect view=default, button-like.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect view=default, chipView=default, chipType=text, isTargetAmount.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect view=default, chipView=default, chipType=text.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect view=default, chipView=default, isTargetAmount.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- MultiSelect view=default, selectAllOptions.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- afterList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- basic logic.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- beforeList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- behavior nesting lists within scroll.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- chipView=accent multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- chipView=default multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- chipView=secondary multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- flip.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- flow, multiselect missing value in items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- renderSelectionIcon multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- renderSelectionIcon single.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- selectAll button.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- shift.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- singleLine=false, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- singleLine=false, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- singleLine=true, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- singleLine=true, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- treeView, arrowPlacement=left, multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- treeView, arrowPlacement=left.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- treeView, arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- treeView, multiSelect arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- treeView, multiple mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- treeView, single mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- view=positive, size=s, labelPlacement=outer.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- view=warning.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/Select/Select -- without closeAfterSelect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextArea/TextArea -- autoResize, maxAuto.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextArea/TextArea -- autoResize.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextArea/TextArea -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextArea/TextArea -- focused.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextArea/TextArea -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextArea/TextArea -- view=warning, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/chromium/TextField/TextField -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- afterList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- beforeList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- flip.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- listMaxHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- listWidth.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- renderItem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- view=positive, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- view=warning.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- virtual dynamic height.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Autocomplete/Autocomplete -- virtual.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- afterList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- beforeList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- behavior nesting lists within scroll.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- chipView=accent multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- chipView=default multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- chipView=secondary multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- flip.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- flow async items loading.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- flow, multiple missing value in items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- flow, multiple update label after getting new items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- flow, single update label after getting new items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- listMaxHeight with long list.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- listMaxHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- listWidth.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- renderItem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- renderSelectionIcon.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- selectAll button.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- selectAllSticky.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- shift.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- singleLine=false, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- singleLine=false, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- singleLine=true, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- singleLine=true, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- treeView, arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- treeView, multiple arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- treeView, multiple mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- treeView, single mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- variant.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- view=positive, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- view=warning.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Combobox/Combobox -- virtual.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker dateShortcuts, dateShortcutsPlacement=left, dateShortcutsWidth=5rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker dateShortcuts, dateShortcutsPlacement=right, dateShortcutsWidth=10rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker input date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker select day in popover.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker select month by arrows.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker select month in popover.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker select year by arrows.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- DatePicker select year in popover.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- calendarContainerWidth, calendarContainerHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- case very future date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- controlled datepicker reset date with null.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- controlled datepicker reset date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- default.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- defaultDate, enableContentLeft, enableContentRight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- disabled, readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- input date from calendar.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- input date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- input masked date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- label, leftHelper, placeholder, titleCaption.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- renderFromDate.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- stretch.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- valueError, valueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePicker -- view=default, size=m.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- appearance=clear, firstValueError, secondValueError.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- appearance=clear, firstValueSuccess, secondValueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- appearance=clear, hasClearDivider.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- calendarContainerWidth, calendarContainerHeight.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- controlled datepicker reset date with null.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- controlled datepicker reset date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- dateShortcuts, dateShortcutsPlacement=left, dateShortcutsWidth=5rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- dateShortcuts, dateShortcutsPlacement=right, dateShortcutsWidth=10rem.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- default.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- defaultDate, enableContent.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- disabled, readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- hintText, required, requiredPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- input date, double calendar.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- input date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- input same date.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- label, leftHelper, placeholder, titleCaption.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- renderFromDate.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- stretch.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/DatePicker/DatePickerRange -- valueError, valueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Dropdown/Dropdown -- behavior nesting lists within scroll.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Dropdown/Dropdown -- prop beforeList in items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Dropdown/Dropdown -- prop listWidth.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Dropdown/Dropdown -- prop nested dropdown placement.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Dropdown/Dropdown -- prop offset.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Dropdown/Dropdown -- prop variant, trigger.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Range/Range -- appearance=clear, firstValueError, secondValueError.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Range/Range -- appearance=clear, firstValueSuccess, secondValueSuccess.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Range/Range -- appearance=clear, hasClearDivider.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Range/Range -- disabled & readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Range/Range -- error & success.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect selectAllSticky.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect view=default, button-like, isTargetAmount.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect view=default, button-like.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect view=default, chipView=default, chipType=text, isTargetAmount.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect view=default, chipView=default, chipType=text.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect view=default, chipView=default, isTargetAmount.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- MultiSelect view=default, selectAllOptions.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- afterList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- basic logic.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- beforeList.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- behavior nesting lists within scroll.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- chipView=accent multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- chipView=default multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- chipView=secondary multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- flip.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- flow, multiselect missing value in items.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- readOnly.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- renderSelectionIcon multiple.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- renderSelectionIcon single.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- selectAll button.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- shift.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- singleLine=false, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- singleLine=false, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- singleLine=true, treeView=false.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- singleLine=true, treeView=true.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- treeView, arrowPlacement=left, multiselect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- treeView, arrowPlacement=left.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- treeView, arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- treeView, multiSelect arrowPlacement=right.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- treeView, multiple mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- treeView, single mode.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- view=positive, size=s, labelPlacement=outer.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- view=warning.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/Select/Select -- without closeAfterSelect.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextArea/TextArea -- autoResize, maxAuto.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextArea/TextArea -- autoResize.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextArea/TextArea -- disabled.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextArea/TextArea -- focused.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextArea/TextArea -- view=negative.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextArea/TextArea -- view=warning, size=s.snap.pngis excluded by!**/*.pngcypress/snapshots/os/webkit/TextField/TextField -- disabled.snap.pngis excluded by!**/*.png
📒 Files selected for processing (20)
packages/plasma-new-hope/src/components/Combobox/Combobox.styles.tspackages/plasma-new-hope/src/components/Combobox/Combobox.tokens.tspackages/plasma-new-hope/src/components/Combobox/ui/SelectAll/SelectAll.styles.tspackages/plasma-new-hope/src/components/Combobox/ui/TreeList/TreeList.styles.tspackages/plasma-new-hope/src/components/Dropdown/Dropdown.styles.tspackages/plasma-new-hope/src/components/Select/Select.styles.tspackages/plasma-new-hope/src/components/Select/Select.tokens.tspackages/plasma-new-hope/src/components/Select/ui/SelectAll/SelectAll.styles.tspackages/plasma-new-hope/src/components/Select/ui/TreeList/TreeList.styles.tspackages/sdds-os/src/components/Attach/Attach.config.tspackages/sdds-os/src/components/Autocomplete/Autocomplete.config.tspackages/sdds-os/src/components/Avatar/Avatar.config.tsxpackages/sdds-os/src/components/Badge/Badge.config.tspackages/sdds-os/src/components/Combobox/Combobox.config.tspackages/sdds-os/src/components/DatePicker/DatePicker.config.tspackages/sdds-os/src/components/Dropdown/Dropdown.config.tspackages/sdds-os/src/components/Range/Range.config.tspackages/sdds-os/src/components/Select/Select.config.tspackages/sdds-os/src/components/TextArea/TextArea.config.tspackages/sdds-os/src/components/TextField/TextField.config.ts
Comment on lines
+65
to
+69
| ${tokens.textFieldBorderColor}: var(--outline-positive); | ||
|
|
||
| ${tokens.textFieldBackgroundColor}: var(--surface-solid-primary); | ||
| ${tokens.textFieldBackgroundColorHover}: var(--surface-solid-primary-hover); | ||
| ${tokens.textFieldBackgroundColorFocus}: var(--surface-solid-primary); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Set the semantic focused border in every Autocomplete view.
The positive, warning, and negative views set only tokens.textFieldBorderColor. They retain the default --outline-primary value for tokens.textFieldBorderColorFocus. This differs from the semantic Combobox and Select mappings.
packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts#L65-L69: addtokens.textFieldBorderColorFocus: var(--outline-positive).packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts#L110-L114: addtokens.textFieldBorderColorFocus: var(--outline-warning).packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts#L155-L159: addtokens.textFieldBorderColorFocus: var(--outline-negative).
📍 Affects 1 file
packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts#L65-L69(this comment)packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts#L110-L114packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts#L155-L159
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/sdds-os/src/components/Autocomplete/Autocomplete.config.ts` around
lines 65 - 69, Update the positive, warning, and negative Autocomplete view
mappings in Autocomplete.config.ts so each sets tokens.textFieldBorderColorFocus
to its matching semantic outline color: --outline-positive at lines 65-69,
--outline-warning at lines 110-114, and --outline-negative at lines 155-159.
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Irinkv
approved these changes
Aug 12, 2026
TitanKuzmich
approved these changes
Aug 13, 2026
Collaborator
|
@oki1oki Нужно в этом пр сделать
Например для ${buttonTokens.buttonColorHover}: var(--inverse-text-primary-hover);
${buttonTokens.buttonColorActive}: var(--inverse-text-primary-active);
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDDS-OS
TextField-like
Dropdown, Select
changelogот25.02.2026What/why changed
Summary by CodeRabbit