mfov-as-tile-match-fix-20260819 - #245
Open
trautmane wants to merge 3 commits into
Open
Conversation
…ll region 01 MFOV-as-tile stacks
There was a problem hiding this comment.
Pull request overview
This PR adjusts default mfov-as-tile cross-match parameterization by adding an additional (third) matching stage to improve connectivity across z-layers in certain small mfov-as-tile stacks, and updates a related test helper to point at a different wafer61 stack.
Changes:
- Add a third cross-match pass for mfov-as-tile (render scales now 0.2, 0.3, 0.5; minInliers 150).
- Update the wafer61 stack name used by
ClusterCountClientTest.findWafer61Clusters().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| render-ws-java-client/src/main/java/org/janelia/render/client/parameter/MFOVAsTileParameters.java | Adds a third mfov-as-tile cross-match stage (pass3) at renderScale 0.5. |
| render-ws-java-client/src/test/java/org/janelia/render/client/ClusterCountClientTest.java | Updates the hardcoded wafer61 stack string used by the manual cluster-finding helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ive' pass can be excluded or included as needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a third cross match derivation pass for mfov-as-tile to resolve unconnected z-layers for small r01 mfov-as-tile stacks in w61_s160_r01 to w61_s178_r00. This solved the connection problems in that area. At some point, I should measure how much it increases the work done for 'all-resin' mfov-as-tiles. If the increase is significant, we'll want to parameterize this additional pass so that it is only used when needed.