test(ipc): add malformed-envelope host gate (refs #586) - #735
Draft
rwrife wants to merge 2 commits into
Draft
Conversation
- Add ipc_wire_malformed host fixture for v0 invalid-message branches - Wire target into test.sh and validate_bundle TEST_TARGETS - Cross-link docs/abi/ipc-wire.md to the new verification harness
rwrife
force-pushed
the
fix/ipc-wire-malformed-harness-586
branch
from
July 30, 2026 21:04
0649054 to
7ac54a9
Compare
20 tasks
Owner
Author
|
Maintenance refresh (2026-07-30): rebased this branch onto current origin/main by replaying only the implementation commits and dropping stale plans/secureos-daily-maintenance-state.md churn.\n\nRe-run evidence on refreshed head (7ac54a9):\n- bash build/scripts/test.sh ipc_wire_malformed\n- bash build/scripts/test.sh ipc_sync_v0\n- bash build/scripts/test.sh ipc_bounds\n- bash build/scripts/test.sh validate_abi_stamps\n\nAll pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/ipc_wire_malformed_test.chost fixture for v0 malformed-envelope rejection pathsbuild/scripts/test_ipc_wire_malformed.shand wireipc_wire_malformedintobuild/scripts/test.shipc_wire_malformedtobuild/scripts/validate_bundle.shTEST_TARGETSdocs/abi/ipc-wire.mdto the new verification harness and refresh its ABI stampWhat this validates now
ipc_send(..., NULL)returnsIPC_ERR_INVALID_MSGabi_versionmismatch returnsIPC_ERR_INVALID_MSGflags(MBZ) violation returnsIPC_ERR_INVALID_MSGpayload_len > IPC_MSG_PAYLOAD_MAXreturnsIPC_ERR_INVALID_MSGsender_subject == 0is rejected byipc_recvwithIPC_ERR_INVALID_MSGTest evidence
bash build/scripts/test.sh ipc_wire_malformed✅bash build/scripts/test.sh ipc_sync_v0✅bash build/scripts/test.sh ipc_bounds✅bash build/scripts/test.sh validate_abi_stampsdocs/abi/manifest.mdstamp drift (ABI_STAMP:FAIL:docs/abi/manifest.md:stamp=9d9ea25e85:last_content=e884cadd29), not introduced by this branch.Follow-ups
The current v0 IPC surface is typed (
ipc_msg_v0) and does not expose a raw byte-frame parser/opcode field, so truncated-header/underflow/unknown-opcode cases from #586 are not directly representable yet. This PR lands the currently enforceable malformed-contract slice and leaves raw-frame negative-path expansion for a follow-up once that surface exists.Refs #586