Add unsound advisory for lockfree - #3174
Open
tooson9010-spec wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
lockfree(601,950 recent downloads per crates.io)Links to upstream issue(s) or PR(s)
https://gitlab.com/bzim/lockfree/-/issues/7
Severity
Two independent soundness problems, both reachable from safe Rust and confirmed with sanitizers.
Map::into_iterdrops the caller-supplied hasher before committing withmem::forget(self), so a panickingH::dropleaves the unwindingMapto drop it again — use-after-free / double-free under AddressSanitizer, with an empty map.SharedIncin::clearwritesmem::uninitialized::<Arc<_>>()into a live field, which Miri reports as undefined behavior with no panic or concurrency involved; the macro is instantiated five times. No fixed release.Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date