Skip to content

Improving errors for DNS name parsing - #533

Draft
ctz wants to merge 8 commits into
mainfrom
jbp-improve-dns-errors
Draft

Improving errors for DNS name parsing#533
ctz wants to merge 8 commits into
mainfrom
jbp-improve-dns-errors

Conversation

@ctz

@ctz ctz commented Aug 27, 2026

Copy link
Copy Markdown
Member

(exploratory currently, opened just for CI)

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.84%. Comparing base (05be248) to head (c2ce8a1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/subject_name/dns_name.rs 94.11% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   97.63%   97.84%   +0.21%     
==========================================
  Files          20       20              
  Lines        4099     4135      +36     
==========================================
+ Hits         4002     4046      +44     
+ Misses         97       89       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ctz added 4 commits August 27, 2026 16:53
If we saw a `MalformedDnsIdentifier` error when considering names, this is a
more proximate cause of what was previously reported as `CertNotValidForName`.
@ctz
ctz force-pushed the jbp-improve-dns-errors branch from e23d12d to be6f013 Compare August 27, 2026 20:37
@ctz

ctz commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

(having slept on it, I am instead planning on putting this information into InvalidNameContext, so each name in there also comes with an optional error expressing why it wasn't considered. I think that will produce a more useful error.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant