Popup anchor system refinement - #4646
Open
Murmele wants to merge 46 commits into
Open
Conversation
8 tasks
Murmele
marked this pull request as ready for review
July 28, 2026 05:51
Murmele
requested review from
MarijnS95,
daxpedda,
jackpot51,
kchibisov and
madsmtm
as code owners
July 28, 2026 05:51
#Conflicts: # winit-appkit/src/window_delegate.rs # winit/src/changelog/unreleased.md
Murmele
commented
Aug 10, 2026
Murmele
commented
Aug 10, 2026
ogoffart
reviewed
Aug 12, 2026
ogoffart
left a comment
ogoffart
left a comment
Contributor
There was a problem hiding this comment.
maybe there should be an example?
| use dpi::{ | ||
| LogicalPosition, LogicalSize, PhysicalInsets, PhysicalPosition, PhysicalSize, Position, Size, | ||
| }; | ||
| pub use positioner::{WindowAnchor, WindowConstraintAdjustment, WindowGravity, place_window}; |
Contributor
There was a problem hiding this comment.
But we can't re-use it for ChildWindow in Slint because slint-core don't depend on winit on purpose.
in fact, the implementation of that function might be better placed in winit-common
Previously every close request left the event_loop which is not correct when only a popup closes
Reason: otherwise the popup might disappear behind the task bar
Contributor
Author
winit-common depends on winit-core so we cannot use this as well. It has to be public otherwise the winit-win32 crate and the macos crate are not able to access it |
ogoffart
reviewed
Aug 19, 2026
Reason: otherwise the popup will be placed wrongly
… no parent is specified
Reason: set_size will trigger already the event loop and will clear the flag as well when not maximized
ogoffart
approved these changes
Aug 21, 2026
#Conflicts: # winit-core/src/window.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement possibility to change the anchor properties of a popup on wayland and imitate the behaviour for other platforms which do not support such anchoring system
changelogmodule if knowledge of this change could be valuable to usersTested on:
X11Does not support popupsIn the example for wayland when clicking outside of the window all popups get closed
with_active(request keyboard grab) istrue. Setting in the exampleactivetofalsethe popup will not be dismissed by the compositor. It is just because it looses the grab and then it gets dismissed