Skip to content

Various improvements to team member validation - #2703

Open
steffahn wants to merge 1 commit into
rust-lang:mainfrom
steffahn:refactor-duplicate-detection
Open

Various improvements to team member validation#2703
steffahn wants to merge 1 commit into
rust-lang:mainfrom
steffahn:refactor-duplicate-detection

Conversation

@steffahn

Copy link
Copy Markdown
Member
  • refactor the duplication check
  • add checks for duplicate roles of a person in a team
  • check against invalid roles of alumni

supersedes both #2701 and #2702

@github-actions

Copy link
Copy Markdown
Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github

@steffahn
steffahn force-pushed the refactor-duplicate-detection branch 2 times, most recently from 4847aba to 6be2d62 Compare August 21, 2026 17:46
- refactor the duplication check
- add checks for duplicate roles
- check against invalid roles of alumni
@steffahn
steffahn force-pushed the refactor-duplicate-detection branch from 6be2d62 to bb746a7 Compare August 21, 2026 17:49
@steffahn

Copy link
Copy Markdown
Member Author

By running the overlap check only on the already individually-deduplicated list of members+alumni, something like e.g. a duplicate alumni won't result in a sequence of multiple of error messages as it currently does

before

[ERROR rust_team::validate] validation error: team `myteam` has duplicate alumni: foobar
[ERROR rust_team::validate] validation error: team `myteam` has duplicate leads + alumni: foobar
[ERROR rust_team::validate] validation error: team `myteam` has duplicate members + alumni: foobar

after

[ERROR rust_team::validate] validation error: team `myteam` has duplicate alumni: `foobar`

The choice of IndexMap and BTreeSet in the new no_duplicates code produces less arbitrary orderings, no longer based on hashes but on order of (first) occurrence in the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant