Various improvements to team member validation - #2703
Open
steffahn wants to merge 1 commit into
Open
Conversation
steffahn
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
marcoieni and
ubiratansoares
as code owners
August 21, 2026 17:15
steffahn
force-pushed
the
refactor-duplicate-detection
branch
from
August 21, 2026 17:20
607fc1e to
56ea82b
Compare
Dry-run check results |
steffahn
force-pushed
the
refactor-duplicate-detection
branch
2 times, most recently
from
August 21, 2026 17:46
4847aba to
6be2d62
Compare
- refactor the duplication check - add checks for duplicate roles - check against invalid roles of alumni
steffahn
force-pushed
the
refactor-duplicate-detection
branch
from
August 21, 2026 17:49
6be2d62 to
bb746a7
Compare
Member
Author
|
By running the overlap check only on the already individually-deduplicated list of members+alumni, something like e.g. a duplicate alumni won't result in a sequence of multiple of error messages as it currently does before after The choice of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes both #2701 and #2702