Fix issue 7061 - #7070
Closed
AsthaMishra wants to merge 4 commits into
Closed
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue :
semicolon_for_stmtgroupedloopwithfor,whileand discarded trailing semicolon. This is correct forforandwhileas they evaluate to()butloopcan evaluate to some value. so whenloop { break v }has the type ofvand semicolon discarded then it becomes a bare expression statement, which rustc requires to be(). that's why we got compilation error.Fix: check the loop body, if it breaks with value then keep the trailing semicolon else remove it as before.