Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
rust-lang
/
rust
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
15.5k
Star
117k
Code
Issues
5k+
Pull requests
1.3k
Actions
Projects
Security and quality
6
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
Retire
ItemLikeVisitor
trait
- #96825
#96825
Merged
bors
merged 30 commits into
rust-lang:master
rust-lang/rust:master
from
kckeiks:remove-item-like-visitor-trait
kckeiks/rust:remove-item-like-visitor-trait
Copy head branch name to clipboard
May 17, 2022
Conversation
Commits
30
(30)
Checks
Files changed
Merged
Retire
ItemLikeVisitor
trait
#96825
bors
merged 30 commits into
rust-lang:master
rust-lang/rust:master
from
kckeiks:remove-item-like-visitor-trait
kckeiks/rust:remove-item-like-visitor-trait
Copy head branch name to clipboard
Commits
Commits on May 13, 2022
Remove CheckConstTraitVisitor
Show description for bd2b210
kckeiks
committed
bd2b210
View commit details
Copy full SHA for bd2b210
Browse repository at this point
replace usage of visit_item_likes_in_modules with hir_module_items query
Show description for 0026034
kckeiks
committed
0026034
View commit details
Copy full SHA for 0026034
Browse repository at this point
remove LifeSeeder
Show description for 52f833a
kckeiks
committed
52f833a
View commit details
Copy full SHA for 52f833a
Browse repository at this point
remove DiagnosticItemCollector
Show description for dab0e75
kckeiks
committed
dab0e75
View commit details
Copy full SHA for dab0e75
Browse repository at this point
remove ItemLikeVisitor impl for EntryContext
Show description for fb73ae2
kckeiks
committed
fb73ae2
View commit details
Copy full SHA for fb73ae2
Browse repository at this point
optimize find_item to fetch Item only when needed
Show description for b1f0209
kckeiks
committed
b1f0209
View commit details
Copy full SHA for b1f0209
Browse repository at this point
remove OuterVisitor
Show description for 0ef16fe
kckeiks
committed
0ef16fe
View commit details
Copy full SHA for 0ef16fe
Browse repository at this point
remove LayoutTest
Show description for 45c37da
kckeiks
committed
45c37da
View commit details
Copy full SHA for 45c37da
Browse repository at this point
remove CollectPrivateImplItemsVisitor
Show description for 0a029e2
kckeiks
committed
0a029e2
View commit details
Copy full SHA for 0a029e2
Browse repository at this point
check def_kind before fetching item
Show description for 90685c6
kckeiks
committed
90685c6
View commit details
Copy full SHA for 90685c6
Browse repository at this point
replace hir().def_kind for def_kind query in rustc_passes
Show description for eea16de
kckeiks
committed
eea16de
View commit details
Copy full SHA for eea16de
Browse repository at this point
remove TraitVisitor
Show description for e8ef5bf
kckeiks
committed
e8ef5bf
View commit details
Copy full SHA for e8ef5bf
Browse repository at this point
remove Visitor impl for PrivateItemsInPublicInterfacesChecker
Show description for e166409
kckeiks
committed
e166409
View commit details
Copy full SHA for e166409
Browse repository at this point
add module_items
Show description for cdba1dc
kckeiks
committed
cdba1dc
View commit details
Copy full SHA for cdba1dc
Browse repository at this point
remove TestItemNamesVisitor
Show description for 52d721c
kckeiks
committed
52d721c
View commit details
Copy full SHA for 52d721c
Browse repository at this point
remove DebuggerVisualizerCollector
Show description for 885b90b
kckeiks
committed
885b90b
View commit details
Copy full SHA for 885b90b
Browse repository at this point
remove HirVisitor
Show description for 0b7dd95
kckeiks
committed
0b7dd95
View commit details
Copy full SHA for 0b7dd95
Browse repository at this point
remove ItemLikeVisitor and DeepVisitor
Show description for 93616dd
kckeiks
committed
93616dd
View commit details
Copy full SHA for 93616dd
Browse repository at this point
update comments about visitor strategy
Show description for 7e44078
kckeiks
committed
7e44078
View commit details
Copy full SHA for 7e44078
Browse repository at this point
rename visit item-like methods
Show description for f975d05
kckeiks
committed
f975d05
View commit details
Copy full SHA for f975d05
Browse repository at this point
change back to using tcx.hir() visit-item method
Show description for 2e98879
kckeiks
committed
2e98879
View commit details
Copy full SHA for 2e98879
Browse repository at this point
update rustdoc code to use new method name
Show description for cad1fd2
kckeiks
committed
cad1fd2
View commit details
Copy full SHA for cad1fd2
Browse repository at this point
change for_each_module's parameter to FnMut
Show description for df11942
kckeiks
committed
df11942
View commit details
Copy full SHA for df11942
Browse repository at this point
use for_each_module instead of iterating over Item's
Show description for 91223ac
kckeiks
committed
91223ac
View commit details
Copy full SHA for 91223ac
Browse repository at this point
avoid converting to DefId from LocalDefId when using query
Show description for 433a5f1
kckeiks
committed
433a5f1
View commit details
Copy full SHA for 433a5f1
Browse repository at this point
remove unnecessary methods from HirIdValidator
Show description for 17e86d9
kckeiks
committed
17e86d9
View commit details
Copy full SHA for 17e86d9
Browse repository at this point
remove redundant branch
Show description for f1c256d
kckeiks
committed
f1c256d
View commit details
Copy full SHA for f1c256d
Browse repository at this point
Commits on May 14, 2022
avoid fetching HIR when handling Impl assoc items
Show description for 959636d
kckeiks
committed
959636d
View commit details
Copy full SHA for 959636d
Browse repository at this point
use opt_item_name to pattern match items with names
Show description for f77658b
kckeiks
committed
f77658b
View commit details
Copy full SHA for f77658b
Browse repository at this point
allocate string only when error will be emitted
Show description for 48fd666
kckeiks
committed
48fd666
View commit details
Copy full SHA for 48fd666
Browse repository at this point
You can’t perform that action at this time.