Skip to content

Only check #[allow(dead_code)] on the trait - #161932

Open
mu001999 wants to merge 1 commit into
rust-lang:mainfrom
mu001999-contrib:dead-code-refactor
Open

Only check #[allow(dead_code)] on the trait#161932
mu001999 wants to merge 1 commit into
rust-lang:mainfrom
mu001999-contrib:dead-code-refactor

Conversation

@mu001999

@mu001999 mu001999 commented Aug 28, 2026

Copy link
Copy Markdown
Member

I edited on an old branch (on another machine) when trying to resolve the first comment in #161571, and then force-pushed it. So it introduced the behavior in #157885 partially.

I found this when rebasing #157885, and I was expecting a conflict about this.

r? chenyukang

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 28, 2026
}
}

fn bar() {} //~ ERROR function `bar` is never used

@mu001999 mu001999 Aug 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should success only after #157885.

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants