ByteString clone and FromIterator performance improvements - #160503
Closed
fereidani wants to merge 3 commits into
Closed
ByteString clone and FromIterator performance improvements#160503fereidani wants to merge 3 commits into
fereidani wants to merge 3 commits into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
Contributor
|
☔ The latest upstream changes (presumably #161783) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are minor performance improvements for #134915,
The new
FromIteratorimplementation avoids allocation and copy for the first element and reuses its buffer instead of constructing an emptyByteString.I also notice that
impl ByteStringis missing#unstableand fixed it.r? joshtriplett