Skip to content

Rollup of 2 pull requests - #159350

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-V056aOq
Jul 15, 2026
Merged

Rollup of 2 pull requests#159350
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-V056aOq

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

raushan728 and others added 4 commits July 15, 2026 12:08
The `addr2line` upgrade also upgrades `gimli`, and we need a new
`unwinding` to align on that. No code changes are required.
std: upgrade `addr2line`, `object`, `miniz_oxide`

The `addr2line` upgrade also upgrades `gimli`, and we need a new
`unwinding` to align on that. No code changes are required.

See also rust-lang/backtrace-rs#765, but since `std` uses that as a
`#[path] mod backtrace_rs`, we don't need to wait for the crate update.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jul 15, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit abc46f4 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
…uwer

Rollup of 2 pull requests

Successful merges:

 - #158764 (Improve E0277 for imperfect derives)
 - #159345 (std: upgrade `addr2line`, `object`, `miniz_oxide`)
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2026
@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7dfe982 failed: CI. Failed job:

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@rust-bors

This comment has been minimized.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2026
@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 18m 47s
Pushing d0babd8 to main...

@rust-bors
rust-bors Bot merged commit d0babd8 into rust-lang:main Jul 15, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 15, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#158764 Improve E0277 for imperfect derives 2cbb583e3c2727ef4ee93d8daff985565b6e445d (link)
#159345 std: upgrade addr2line, object, miniz_oxide ceadccd274f91943e7ce92ee26ddea2eff824257 (link)

previous master: 2118366bbf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2118366 (parent) -> d0babd8 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d0babd8b6b05ef9bb65d42f928cef4129d64cf65 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 14m 33s -> 6m 21s (-56.3%)
  2. dist-x86_64-apple: 1h 31m -> 2h 15m (+48.6%)
  3. x86_64-gnu-aux: 1h 45m -> 2h 31m (+43.1%)
  4. dist-apple-various: 1h 28m -> 2h 1m (+37.6%)
  5. x86_64-gnu-llvm-22-1: 1h 9m -> 46m 10s (-33.8%)
  6. dist-loongarch64-linux: 1h 21m -> 1h 48m (+33.7%)
  7. dist-x86_64-mingw: 2h 3m -> 2h 40m (+29.7%)
  8. x86_64-msvc-ext2: 1h 24m -> 1h 48m (+28.5%)
  9. dist-powerpc64-linux-gnu: 1h 13m -> 1h 33m (+27.4%)
  10. dist-powerpc64le-linux-gnu: 1h 38m -> 1h 12m (-26.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d0babd8): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.5%] 7
Regressions ❌
(secondary)
0.3% [0.2%, 0.5%] 26
Improvements ✅
(primary)
-0.8% [-0.9%, -0.8%] 4
Improvements ✅
(secondary)
-2.9% [-5.1%, -0.7%] 2
All ❌✅ (primary) -0.1% [-0.9%, 0.5%] 11

Max RSS (memory usage)

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.4% [2.7%, 4.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.1%, secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.1%] 4
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.6%] 1
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 4

Bootstrap: 490.55s -> 491.731s (0.24%)
Artifact size: 390.05 MiB -> 390.07 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 15, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

Caused by #159345 (comment)
@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 16, 2026
@JonathanBrouwer
JonathanBrouwer deleted the rollup-V056aOq branch August 21, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants