Skip to content

fix(integer_division_remainder_used): also detect inherent division/r… #17618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
durationextender wants to merge 1 commit into
base: master
Choose a base branch
from
+83 −10
Open

fix(integer_division_remainder_used): also detect inherent division/r… #17618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions clippy_lints/src/operators/integer_division_remainder_used.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,40 @@ pub(super) fn check(cx: &LateContext<'_>, op: BinOpKind, lhs: &Expr<'_>, rhs: &E
);
}
}
// check method call is present in specific list if yes also lint it
pub(super) fn check_method_call(cx: &LateContext<'_>, method_name: &str, receiver: &Expr<'_>, span: Span) {
Comment on lines +25 to +26

@CommanderStorm CommanderStorm Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem like very usefull docs.. I can see this by glossing over the fn..
Also not a doc comment

Suggested change
// check method call is present in specific list if yes also lint it
pub(super) fn check_method_call(cx: &LateContext<'_>, method_name: &str, receiver: &Expr<'_>, span: Span) {
pub(super) fn check_method_call(cx: &LateContext<'_>, method_name: &str, receiver: &Expr<'_>, span: Span) {

let instance_ty = cx.typeck_results().expr_ty(receiver);

@CommanderStorm CommanderStorm Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the order here that we first check the name, then cx.typeck_results... since performance wise this is the better order

if matches!(
method_name,
"checked_div"
| "checked_div_euclid"
| "checked_div_exact"
| "checked_rem"
| "checked_rem_euclid"
| "div_ceil"
| "div_euclid"
| "div_exact"
| "overflowing_div"
| "overflowing_div_euclid"
| "overflowing_rem"
| "overflowing_rem_euclid"
| "rem_euclid"
| "strict_div"
| "strict_div_euclid"
| "saturating_div"
| "strict_rem"
| "strict_rem_euclid"
| "wrapping_div"
| "wrapping_div_euclid"
| "wrapping_rem"
| "wrapping_rem_euclid"
Comment on lines +30 to +51

@CommanderStorm CommanderStorm Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check using sym::* instead, since more efficient (?), better typed, ... and generally superiour

) && matches!(instance_ty.peel_refs().kind(), ty::Int(_) | ty::Uint(_))
{
span_lint(
cx,
INTEGER_DIVISION_REMAINDER_USED,
span.source_callsite(),
format!("use of `{method_name}` has been disallowed in this context"),
);
}
}
3 changes: 3 additions & 0 deletions clippy_lints/src/operators/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,9 @@ impl<'tcx> LateLintPass<'tcx> for Operators {
);
manual_div_ceil::check(cx, e, op.node, lhs, rhs, self.msrv);
},
ExprKind::MethodCall(path, receiver, _args, span) => {
integer_division_remainder_used::check_method_call(cx, path.ident.name.as_str(), receiver, span);
},
ExprKind::AssignOp(op, lhs, rhs) => {
let bin_op = op.node.into();
if !e.span.from_expansion() {
Expand Down
15 changes: 15 additions & 0 deletions tests/ui/integer_division_remainder_used.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,21 @@ impl std::ops::Rem for CustomOps {
}
}

fn issue17603() {
let x: u16 = 7;
let _ = x.div_ceil(3);
//~^ integer_division_remainder_used

let _ = x.wrapping_div(3);
//~^ integer_division_remainder_used

let _ = x.checked_rem(3);
//~^ integer_division_remainder_used

let f: f64 = 7.0;
let _ = f.div_euclid(3.0);
}
Comment on lines +23 to +35

@CommanderStorm CommanderStorm Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for each of the methods noted above, I would expect one testcase, so please copy paste the list and add a testcase for each 😉

Since div_euclid does not lint here, also keep the cases where it lints and does not for each.


fn main() {
// should trigger
let a = 10;
Expand Down
38 changes: 28 additions & 10 deletions tests/ui/integer_division_remainder_used.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,59 +13,77 @@ error: use of `%` has been disallowed in this context
LL | Self(self.0 % rhs.0)
| ^^^^^^^^^^^^^^

error: use of `div_ceil` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:24:15
|
LL | let _ = x.div_ceil(3);
| ^^^^^^^^^^^

error: use of `wrapping_div` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:27:15
|
LL | let _ = x.wrapping_div(3);
| ^^^^^^^^^^^^^^^

error: use of `checked_rem` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:30:15
|
LL | let _ = x.checked_rem(3);
| ^^^^^^^^^^^^^^

error: use of `/` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:26:13
--> tests/ui/integer_division_remainder_used.rs:41:13
|
LL | let c = a / b;
| ^^^^^

error: use of `%` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:28:13
--> tests/ui/integer_division_remainder_used.rs:43:13
|
LL | let d = a % b;
| ^^^^^

error: use of `/` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:30:13
--> tests/ui/integer_division_remainder_used.rs:45:13
|
LL | let e = &a / b;
| ^^^^^^

error: use of `%` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:32:13
--> tests/ui/integer_division_remainder_used.rs:47:13
|
LL | let f = a % &b;
| ^^^^^^

error: use of `/` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:34:13
--> tests/ui/integer_division_remainder_used.rs:49:13
|
LL | let g = &a / &b;
| ^^^^^^^

error: use of `%` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:36:13
--> tests/ui/integer_division_remainder_used.rs:51:13
|
LL | let h = &10 % b;
| ^^^^^^^

error: use of `/` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:38:13
--> tests/ui/integer_division_remainder_used.rs:53:13
|
LL | let i = a / &4;
| ^^^^^^

error: use of `/` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:43:5
--> tests/ui/integer_division_remainder_used.rs:58:5
|
LL | j /= 2;
| ^^^^^^

error: use of `%` has been disallowed in this context
--> tests/ui/integer_division_remainder_used.rs:45:5
--> tests/ui/integer_division_remainder_used.rs:60:5
|
LL | j %= 3;
| ^^^^^^

error: aborting due to 11 previous errors
error: aborting due to 14 previous errors

Loading