fix(while_let_loop): detect the pattern when the loop has a label - #17614
Open
durationextender wants to merge 1 commit into
Open
fix(while_let_loop): detect the pattern when the loop has a label#17614durationextender wants to merge 1 commit into
durationextender wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. |
This comment has been minimized.
This comment has been minimized.
DanielEScherzer
approved these changes
Aug 23, 2026
| /// Checks if `block` contains a single unlabeled `break` expression or statement, possibly embedded | ||
| /// inside other blocks. | ||
| fn is_simple_break_block(block: &Block<'_>) -> bool { | ||
| /// Checks if `block` contains a single unlabeled and importantly now also a labeled `break` |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Checks if `block` contains a single unlabeled and importantly now also a labeled `break` | |
| /// Checks if `block` contains a single (labeled or unlabeled) `break` |
the "now" part is confusing, since we don't normally reference older versions of the code outside of regression tests; unclear why this is marked as "importantly"
| /// Checks if `expr` contains a single unlabeled `break` expression or statement, possibly embedded | ||
| /// inside other blocks. | ||
| fn is_simple_break_expr(expr: &Expr<'_>) -> bool { | ||
| /// Checks if `expr` contains a single unlabeled and importantly now also a labeled `break` |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Checks if `expr` contains a single unlabeled and importantly now also a labeled `break` | |
| /// Checks if `expr` contains a single (labeled or unlabeled ) `break` |
per above
CommanderStorm
suggested changes
Aug 23, 2026
Contributor
Author
|
Should be good now i hope. @rustbot ready |
durationextender
force-pushed
the
fix/while-let-loop-label-detection
branch
from
August 23, 2026 16:21
3d03892 to
98939c0
Compare
Collaborator
|
Gri-ffin
reviewed
Aug 24, 2026
|
As I mentioned in #17590, a while-let loop is allowed to be labeled, so the label should be preserved even if it's only a "comment" about what the loop is doing. |
Contributor
Sorry, you still have @rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while_let_loopwasn't firing when the loop had a label, since the break check assumed no label. Now it also acceptsbreak 'labelwhen it matches the loop's own label, while still ignoring breaks meant for a different outer loop.Covers
if let/else,let else, andmatchversions.fixes #17590
changelog: [
while_let_loop]: detect the pattern even when the enclosing loop has a label