Skip to content

test: cover mutable iterator chains in chunks_exact_to_as_chunks - #17599

Open
cuishuang wants to merge 1 commit into
rust-lang:masterfrom
cuishuang:add-test
Open

test: cover mutable iterator chains in chunks_exact_to_as_chunks#17599
cuishuang wants to merge 1 commit into
rust-lang:masterfrom
cuishuang:add-test

Conversation

@cuishuang

@cuishuang cuishuang commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The mutable suggestion for chunks_exact_to_as_chunks was already fixed by #17316, but the exact for_each reproducer reported in #17593 was not covered by the rustfix tests.

This adds regression coverage for:

  • mutation through for_each;
  • mutation through a map/collect iterator chain;
  • the generated .iter_mut() suggestions compiling after rustfix.

Refs #17593

changelog: none

Signed-off-by: cuishuang <imcusg@gmail.com>
@rustbot

rustbot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

@rustbot rustbot added S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 21, 2026

@CommanderStorm CommanderStorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community review: lgtm

View changes since this review

@DanielEScherzer DanielEScherzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

community review: extra tests are good

View changes since this review

@rustbot rustbot removed the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 23, 2026
@rustbot

rustbot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

r? @Jarcho

rustbot has assigned @Jarcho for the project review.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 9 candidates
  • 9 candidates expanded to 9 candidates
  • Random selection from Jarcho, Manishearth, blyxyas, dswij, llogiq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants