Skip to content

unused_trait_names: make the suggestion nicer - #17589

Open
ada4a wants to merge 1 commit into
rust-lang:masterfrom
ada4a:push-ulukovwzrwkw
Open

unused_trait_names: make the suggestion nicer#17589
ada4a wants to merge 1 commit into
rust-lang:masterfrom
ada4a:push-ulukovwzrwkw

Conversation

@ada4a

@ada4a ada4a commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
  • make the message more descriptive
  • reduce the diff
  • make the suggestion verbose, so that the diff can be color-coded (and because it'd get formatted awkwardly otherwise)

changelog: none
(because the change is not that significant imo)

- make the message more descriptive
- reduce the diff
- make the suggestion verbose, so that the diff can be color-coded
  (and because it'd get formatted awkwardly otherwise)
@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

@rustbot rustbot added S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 19, 2026

@CommanderStorm CommanderStorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

community reivew: both are fine imo, not really a diff from my POV 🤷🏻‍♂️

View changes since this review

@github-actions

Copy link
Copy Markdown

Lintcheck changes for feda972

Lint Added Removed Changed
clippy::unused_trait_names 0 0 852

This comment will be updated if you push new changes

@ada4a

ada4a commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

I mean you're not wrong.. I'm just a sucker for smaller diffs^^

@CommanderStorm

CommanderStorm commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

not really a diff from my POV

I'm just a sucker for smaller diffs

I meant "not really a substantial difference from my point of view", not git diff 😉
Misleadingly worded.

@ada4a

ada4a commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

And I meant "diff" as in "suggestion diff" 😅 Meaning this:

use Trait as _;
          ++++

instead of this:

- use Trait;
+ use Trait as _;

@rustbot rustbot removed the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants