fix(lints): avoid method-name false positives in suspicious_operation… - #17580
Open
NicDevTV wants to merge 4 commits into
Open
fix(lints): avoid method-name false positives in suspicious_operation…#17580NicDevTV wants to merge 4 commits into
NicDevTV wants to merge 4 commits into
Conversation
rustbot
added
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
CommanderStorm
approved these changes
Aug 17, 2026
Comment on lines
+588
to
+594
| (MethodCall(left, ..), MethodCall(right, ..)) => { | ||
| // A method name is part of the expression's structure, not a | ||
| // candidate for the identifier swap this lint is looking for. | ||
| if !eq_id(left.seg.ident, right.seg.ident) { | ||
| return (IdentDifference::NonIdent, base); | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
lets simplify..
Also I don't think the comment is very insightfull and mostly just stating the obvious...
Suggested change
| (MethodCall(left, ..), MethodCall(right, ..)) => { | |
| // A method name is part of the expression's structure, not a | |
| // candidate for the identifier swap this lint is looking for. | |
| if !eq_id(left.seg.ident, right.seg.ident) { | |
| return (IdentDifference::NonIdent, base); | |
| } | |
| }, | |
| (MethodCall(left, ..), MethodCall(right, ..)) if eq_id(left.seg.ident, right.seg.ident) => { | |
| // keep going | |
| }, |
Contributor
|
make sure to squash your commits so that this does not create an unnessary review cycle.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a false positive in
suspicious_operation_groupingsSummary
suspicious_operation_groupingstreated different method names as identifier changes and could suggest invalid replacements, such as replacinghas_authority()withis_file().This change compares method names before calculating identifier differences. Expressions using different methods are treated as incompatible, while receiver mismatches with the same method name are still detected.
Added regression tests for both cases.
Testing
cargo fmt --all -- --checkgit diff --checkrustc_private; only Stable Rust is installed.changelog: [
suspicious_operation_groupings]: avoid false-positive suggestions for expressions that call different methodsfixes #6747