Remove rust-tools-util - #17574
Open
Jarcho wants to merge 2 commits into
Open
Conversation
* Move all argument parsing into a single loop. * Print an error when `--explain` is missing an argument. * Print an error when there are multiple `--explain` arguments. * Don't parse flags after `--`
* Only produce a single version string in the build script
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-community-reviews
CommanderStorm
approved these changes
Aug 18, 2026
| @@ -1,153 +1,166 @@ | |||
| // We need this feature as it changes `dylib` linking behavior and allows us to link to | |||
| // `rustc_driver`. | |||
| #![feature(rustc_private)] | |||
Contributor
There was a problem hiding this comment.
you sure you want to remove the explainer?
Member
|
FWIW, miri is still using this. But a version from crates.io, so us removing this now should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #17573, but it doesn't really need it. Only the second commit is relevant to this PR.
This removes the
rustc_tools_utilcrate and inlines only the part we actually use.cc @flip1995
changelog: none