Allow floating point (in-)equality comparisons to literals in assert_eq! and assert_ne! macros - #17571
Open
George-Ogden wants to merge 7 commits into
Open
Allow floating point (in-)equality comparisons to literals in assert_eq! and assert_ne! macros#17571George-Ogden wants to merge 7 commits into
assert_eq! and assert_ne! macros#17571George-Ogden wants to merge 7 commits into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-community-reviews
Author
|
r? @llogiq |
rustbot
removed
the
S-waiting-on-community-reviews
George-Ogden
commented
Aug 15, 2026
George-Ogden
force-pushed
the
assert-eq-const-cmp
branch
from
August 15, 2026 15:46
279ca51 to
ac13ae3
Compare
llogiq
approved these changes
Aug 22, 2026
This reverts commit c07b40b.
George-Ogden
force-pushed
the
assert-eq-const-cmp
branch
from
August 22, 2026 14:17
ac13ae3 to
aea8aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
float_cmp_const] Check for floating-point (in-)equality comparisons to constants inassert_eq!andassert_ne!macros.Fixes #17570