Make question_mark to remove redundant block when outer scope will not be polluted - #16936
Open
profetia wants to merge 1 commit into
Open
Make question_mark to remove redundant block when outer scope will not be polluted#16936profetia wants to merge 1 commit into
question_mark to remove redundant block when outer scope will not be polluted#16936profetia wants to merge 1 commit into
Conversation
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
r? clippy |
dswij
reviewed
Aug 8, 2026
| | | ||
|
|
||
| error: aborting due to 47 previous errors | ||
| error: aborting due to 51 previous errors |
Member
There was a problem hiding this comment.
can we also add the case where there is a shadowing inside the block?
e.g.
if let Some(x) = Some(1) {
let x = x + 1;
todo!()
} else {
return None;
};
Collaborator
|
☔ The latest upstream changes (possibly #17607) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16892
Implemented reusing the logic from
match_single_binding.changelog: [
question_mark] remove redundant block when outer scope will not be polluted