improve [match_same_arms] messages, enable rustfix test - #12794
Conversation
rustbot
added
the
S-waiting-on-review
| "", | ||
| appl, | ||
| ) | ||
| .help("or try changing either arm body"); |
There was a problem hiding this comment.
is there a way to ensure the help message is printed after the suggestions?
There was a problem hiding this comment.
Seems like the suggestions are printed after any non-suggestion messages. You can try rephrasing the help messages taking that into account
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
LGTM, thanks! ❤️
Could you rephrase the help messages?
| "", | ||
| appl, | ||
| ) | ||
| .help("or try changing either arm body"); |
There was a problem hiding this comment.
Seems like the suggestions are printed after any non-suggestion messages. You can try rephrasing the help messages taking that into account
|
I've manually done it (I was bored and wanted to take this through the finish line, being that such an easy-to-solve issue was blocking it) @bors r+ |
improve [`match_same_arms`] messages, enable rustfix test closes: #9251 don't worry about the commit size, most of them are generated --- changelog: improve [`match_same_arms`] lint messages
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 1 review requesting changes by reviewers with write access. |
Thanks! that'll do I was too tired back then, and was trying to think of some better help message but ended up fall asleep 🤦♂️ As of the failed test, I've encounter the exactly problem in the past with Alexendoo iirc, it was strange, ended up re-open another PR to solve it, I'll try change the commit message to see if that goes away |
|
I think this happens because of the "requested changes" review. You need to dismiss that (or blyxyas needs to approve it) before bors will merge it. Like here: #12107 (comment) |
did a quick google search and it's telling me that you need write access to dismiss it, well I guess I'll have to rely on blyxyas then 😸 |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
5 participants
closes: #9251
don't worry about the commit size, most of them are generated
changelog: improve [
match_same_arms] lint messages