Skip to content

Add tests_outside_test_module lint - #10543

Merged
bors merged 3 commits into
rust-lang:masterfrom
blyxyas:tests_outside_test_module
Apr 4, 2023
Merged

Add tests_outside_test_module lint#10543
bors merged 3 commits into
rust-lang:masterfrom
blyxyas:tests_outside_test_module

Conversation

@blyxyas

@blyxyas blyxyas commented Mar 24, 2023

Copy link
Copy Markdown
Member

Adds tests_outside_test_module from #10506. This PR doesn't close the issue, just resolves task 1.

changelog: [tests_outside_test_module]: The lint has been added

@rustbot

rustbot commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 24, 2023
@blyxyas blyxyas mentioned this pull request Mar 27, 2023
Closed
3 tasks
@bors

bors commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #9102) made this pull request unmergeable. Please resolve the merge conflicts.

@blyxyas
blyxyas force-pushed the tests_outside_test_module branch from d47144f to f0a6022 Compare March 30, 2023 17:52
@blyxyas blyxyas mentioned this pull request Mar 31, 2023
Merged
@bors

bors commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #10534) made this pull request unmergeable. Please resolve the merge conflicts.

@blyxyas
blyxyas force-pushed the tests_outside_test_module branch from f0a6022 to b2856a7 Compare April 1, 2023 22:35
flip1995
flip1995 reviewed Apr 3, 2023
View reviewed changes
Comment thread clippy_lints/src/tests_outside_test_module.rs Outdated
flip1995
flip1995 approved these changes Apr 4, 2023
View reviewed changes

@flip1995 flip1995 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some major nitpicking.

Comment thread clippy_lints/src/tests_outside_test_module.rs Outdated
Comment thread clippy_lints/src/tests_outside_test_module.rs Outdated
@flip1995

flip1995 commented Apr 4, 2023

Copy link
Copy Markdown
Member

Thanks for addressing everything so quickly!

@bors r+

@bors

bors commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

📌 Commit b2f9191 has been approved by flip1995

It is now in the queue for this repository.

@bors

bors commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit b2f9191 with merge 5d149c5...

@blyxyas

blyxyas commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

They called me Speedy McQuick in high school

@bors

bors commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5d149c5 to master...

@bors
bors merged commit 5d149c5 into rust-lang:master Apr 4, 2023
bors added a commit that referenced this pull request Apr 21, 2023
@bors
Auto merge of #10578 - blyxyas:items_after_test_module, r=dswij
138f692 
Add `items_after_test_module` lint

Resolves task *3* of #10506, alongside *1* resolved at #10543 in an effort to help standarize a little bit more testing modules.

---

changelog:[`items_after_test_module`]: Added the lint.
bors added a commit that referenced this pull request Apr 22, 2023
@bors
Auto merge of #10578 - blyxyas:items_after_test_module, r=dswij
0884d16 
Add `items_after_test_module` lint

Resolves task *3* of #10506, alongside *1* resolved at #10543 in an effort to help standarize a little bit more testing modules.

---

changelog:[`items_after_test_module`]: Added the lint.
bors added a commit that referenced this pull request Apr 23, 2023
@bors
Auto merge of #10578 - blyxyas:items_after_test_module, r=dswij
a3ed905 
Add `items_after_test_module` lint

Resolves task *3* of #10506, alongside *1* resolved at #10543 in an effort to help standarize a little bit more testing modules.

---

changelog:[`items_after_test_module`]: Added the lint.
@blyxyas
blyxyas deleted the tests_outside_test_module branch October 5, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blyxyas @rustbot @bors @flip1995