fix: range pattern inside a parenthesis parsed as tuple pattern - #23242
Open
dfireBird wants to merge 1 commit into
Open
fix: range pattern inside a parenthesis parsed as tuple pattern#23242dfireBird wants to merge 1 commit into
dfireBird wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
reviewed
Aug 28, 2026
| check( | ||
| TopEntryPoint::Expr, | ||
| r#" | ||
| match 1 { |
Member
There was a problem hiding this comment.
Why not create an inline test? Like // test or_pattern
Member
Author
There was a problem hiding this comment.
I used this test, to debug the issue and just kept it 😅
I could replace this.
Member
There was a problem hiding this comment.
Inline testing includes syntax tree, you need cargo xtask codegen
You see crates/parser/test_data/
Member
Author
There was a problem hiding this comment.
Yeah I missed to check the last line, sorry.
Member
Author
There was a problem hiding this comment.
Should I remove this test and only inline then?
dfireBird
force-pushed
the
push-vrtuqvnutkrn
branch
from
August 28, 2026 03:35
349fc35 to
23334ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22985
Let me know if we want to split up the expression.