feat: implement a simple hover auto traits in rpit - #23240
Open
A4-Tacks wants to merge 1 commit into
Open
Conversation
Example
---
```rust
//- minicore: send, unpin
fn foo() -> $0impl Trait {
&raw const ()
}
```
->
> ```rust
> impl Trait + Unpin
> impl Trait = *const ()
> ```
>
> ---
>
> ```rust
> impl
> ```
>
> ---
>
> keyword docs
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Aug 26, 2026
| if traits.is_empty() { None } else { Some(traits.into_iter().collect()) } | ||
| } | ||
|
|
||
| #[salsa::tracked(returns(as_deref))] |
Contributor
There was a problem hiding this comment.
Should IMO be the same query with crate_notable_traits(). Also both should check the presence of the unsafe feature like we do for crate_lang_items().
| Some(HoverResult { markup, actions }) | ||
| } | ||
|
|
||
| pub(super) fn rpit( |
Contributor
There was a problem hiding this comment.
IMO this is the wrong way to fix. We should instead do that in display infra, for every printed opaque.
Granted, it'll need more work because we don't currently carry the Option<GenericDefId> required for trait solving (to get trait_environment()) in display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implement of #23237
Example
->