fix: Fix some subtle bugs in docs rendering - #23235
Open
ChayimFriedman2 wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
commented
Aug 26, 2026
|
|
||
| <span class="comment documentation">/// ```rust</span> | ||
| <span class="comment documentation">///</span><span class="none injected"> </span><span class="keyword injected">let</span><span class="none injected"> </span><span class="punctuation injected">_</span><span class="none injected"> </span><span class="operator injected">=</span><span class="none injected"> </span><span class="function injected">example</span><span class="parenthesis injected">(</span><span class="operator injected">&</span><span class="bracket injected">[</span><span class="numeric_literal injected">1</span><span class="comma injected">,</span><span class="none injected"> </span><span class="numeric_literal injected">2</span><span class="comma injected">,</span><span class="none injected"> </span><span class="numeric_literal injected">3</span><span class="bracket injected">]</span><span class="parenthesis injected">)</span><span class="semicolon injected">;</span> | ||
| <span class="comment documentation">/// </span><span class="keyword injected">let</span><span class="none injected"> </span><span class="punctuation injected">_</span><span class="none injected"> </span><span class="operator injected">=</span><span class="none injected"> </span><span class="function injected">example</span><span class="parenthesis injected">(</span><span class="operator injected">&</span><span class="bracket injected">[</span><span class="numeric_literal injected">1</span><span class="comma injected">,</span><span class="none injected"> </span><span class="numeric_literal injected">2</span><span class="comma injected">,</span><span class="none injected"> </span><span class="numeric_literal injected">3</span><span class="bracket injected">]</span><span class="parenthesis injected">)</span><span class="semicolon injected">;</span> |
Contributor
Author
There was a problem hiding this comment.
This test only removed the none injected classes for the leading space, since it's now trimmed as indentation thus unmapped. No real effect.
ChayimFriedman2
commented
Aug 26, 2026
| --- | ||
| \<- ` ` here | ||
| \<- ` ` here |
Contributor
Author
There was a problem hiding this comment.
I verified with the JSON version of rustdoc that we should indeed emit this non-ASCII space here (besides the fact that I copied that from rustdoc's code).
This comment has been minimized.
This comment has been minimized.
Match the behavior of rustdoc *precisely*: - Fix handling of mixed sugared and desugared docs. - Only trim spaces and tabs for indentation.
ChayimFriedman2
force-pushed
the
docs-sugar-rustdoc
branch
from
August 26, 2026 17:56
81f0eff to
b709a55
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the behavior of rustdoc precisely: