fix panic from out of scope params in opaque hidden types - #23142
Open
im-lunex wants to merge 1 commit into
Open
fix panic from out of scope params in opaque hidden types#23142im-lunex wants to merge 1 commit into
im-lunex wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix panic from out of scope params in opaque hidden types.. this follows rustc's approach of remapping hidden type params into the opaque's parameter space and replacing params that do not belong to the opaque with error type.. also adds a regression test for the reported case
fixes: #23125
NOTE - i intentionally focused on the minimal subset needed just to fix reported bug. rustc also have things for consts, regions, and some closure-specific cases