Re-add stat definition for Vita and 3DS (to fix compilation on main)#5322
Merged
tgross35 merged 1 commit intoJul 24, 2026
Merged
Conversation
pheki
force-pushed
the
re-add-stat-definition-vita-3ds
branch
from
July 23, 2026 23:51
e739c75 to
e60b389
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-add
statdefinition for Vita and 3DS to fix compilation on mainThis comment made me realize that these targets are failing on main (and I'm one of the target maintainers for
armv7-sony-vita-newlibeabihf).It seems that both were broken by #5061 becasuse of a missing re-export, but at the same time it made me realize that the new definition seems incorrect for the Vita.
VitaSDK uses its own newlib fork, with its
statdefined in https://github.com/vitasdk/newlib/blob/fbb8375870d799758e0b4358d2f1708781aa26a6/newlib/libc/sys/vita/sys/stat.h#L27-L55For horizon, that definition is the same as the old one (and libc-0.2 one), and the discussion in #2795 implies it's correct, but I'm not sure where can we find the canonical headers for it.
Checklist
libc-test/semverhave been updated*LASTor*MAXhave the standarddoc comment
cargo test -p libc-test --target mytarget);especially relevant for platforms that may not be checked in CI
Checked locally using both
./etc/libc-util.py check-all-targets --only {target} libcandcargo +nightly check --target {target} -Z build-std=corefor:armv7-sony-vita-newlibeabihfarmv6k-nintendo-3dsAnd TYSM for maintaining
libc!