Add hash_table::OccupiedEntry::replace_entry_with to mirror HashMap API - #669
Merged
Merged
Conversation
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 20:27
1469af1 to
4d7f1f9
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 20:54
4d7f1f9 to
8631463
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 20:57
8631463 to
3876ed7
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 21:03
3876ed7 to
90b4d4b
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 21:06
90b4d4b to
bb69fe1
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 21:25
bb69fe1 to
cc08d25
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 2, 2025 21:26
cc08d25 to
4dd856a
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
commented
Dec 2, 2025
| /// This does not check if the given bucket is actually occupied. | ||
| #[cfg_attr(feature = "inline-more", inline)] | ||
| pub unsafe fn replace_bucket_with<F>(&mut self, bucket: Bucket<T>, f: F) -> bool | ||
| pub(crate) unsafe fn replace_bucket_with<F>( |
Contributor
Author
There was a problem hiding this comment.
pub(crate) is required because MSRV currently will see this as leaking Tag in a public method, even though this method can only be used in the crate itself.
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 2, 2025
Amanieu
reviewed
Dec 3, 2025
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 3, 2025 14:06
4dd856a to
a7a568c
Compare
clarfonthey
force-pushed
the
entry-improvements
branch
from
December 3, 2025 14:06
a7a568c to
840065f
Compare
clarfonthey
added a commit
to clarfonthey/hashbrown
that referenced
this pull request
Dec 3, 2025
Amanieu
added this pull request to the merge queue
Dec 12, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2025
Amanieu
added this pull request to the merge queue
Dec 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also something useful for #666.