add single-crate consistency check, using the sparse index - #3479
Open
syphar wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
changed the title
syphar
force-pushed
the
new-consistency
branch
from
August 27, 2026 08:34
26069f9 to
72f1c14
Compare
syphar
marked this pull request as ready for review
August 27, 2026 08:40
Member
Author
Member
|
Failed CI. |
Member
Author
that test failure is unrelated |
| Ok(crates) | ||
| } | ||
|
|
||
| pub(super) async fn load_single(conn: &mut sqlx::PgConnection, name: &KrateName) -> Result<Crates> { |
Member
There was a problem hiding this comment.
Wouldn't it be better to return Result<Option<Crate>> instead since we always return 0 or 1?
Member
Author
There was a problem hiding this comment.
initially I would have answered we need the list, so we can reuse the same calculate_diff algo that we have for the whole index.
But then I rememnered:
- the algorithm just needs an
Iterator - and
Optionimplements that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thinking about the future where the git index might be only updated once an hours, we need another source for the consistency check.
So with this, when the db is outdated for a single crate, we can just sync that.
I imagine that we could also run a scheduler similar to the repo stats.
the removed
queue.attemptwas obsolete code that's not needed any more( test failure is unrelated)