watcher: Start recording metrics for git index change handling - #3477
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
force-pushed
the
index-handle-metrics
branch
3 times, most recently
from
August 26, 2026 21:14
54765c9 to
765310c
Compare
syphar
changed the title
syphar
force-pushed
the
index-handle-metrics
branch
11 times, most recently
from
August 26, 2026 22:15
c43015c to
b2eb0fc
Compare
syphar
force-pushed
the
index-handle-metrics
branch
from
August 26, 2026 22:18
b2eb0fc to
fa408af
Compare
syphar
changed the title
syphar
marked this pull request as ready for review
August 26, 2026 22:19
Member
Author
GuillaumeGomez
approved these changes
Aug 27, 2026
github-actions
Bot
added
the
S-waiting-on-deploy
github-actions
Bot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preparation for #3349.
For SQS I'm missing one piece of information: How long does it take to handle one change, depending on the type?
Some of the architecture decisions and settings in the sqs subscriber depend on that, at least the visibility timeout, perhaps how many events we can fetch in a batch. Or if we need to
tokio::spawnthe event-handling? not sure. In any case, the data will help.Mainly for the new SQS logic I added some metrics in #3349, so I thought we could also just merge and track these just for the git index. With that data I'll be able to estimate much better.
While we touch it, i also added some
tracing::instrumentmarkers so we have sampled detailed performance traces in sentry.