Skip to content

deploy dev-guide to gh pages - #3456

Merged
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:deploy-pages
Aug 20, 2026
Merged

deploy dev-guide to gh pages#3456
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:deploy-pages

Conversation

@syphar

@syphar syphar commented Aug 18, 2026

Copy link
Copy Markdown
Member

@syphar syphar self-assigned this Aug 18, 2026
@syphar
syphar requested a review from a team as a code owner August 18, 2026 18:22
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 18, 2026
@syphar
syphar force-pushed the deploy-pages branch 2 times, most recently from bec1a23 to f237318 Compare August 18, 2026 18:37
Comment thread .github/workflows/dev-guide.yml Outdated
@rustbot

This comment has been minimized.

@rustbot

rustbot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@syphar
syphar requested a review from GuillaumeGomez August 18, 2026 21:25
Comment thread .github/workflows/ci.yml
@syphar
syphar requested a review from GuillaumeGomez August 18, 2026 23:13
@GuillaumeGomez

Copy link
Copy Markdown
Member

Did you forget to comment/push changes since my last comment?

@syphar

syphar commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

Did you forget to comment/push changes since my last comment?

Not sure? last comment I worked on wednesday was the pull_request_target one,

just now I answered the one about moving the book-test to the separate workflow (and removing it from ci.yml)

Comment thread .github/workflows/dev-guide.yml
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@GuillaumeGomez
GuillaumeGomez merged commit e1bf204 into rust-lang:main Aug 20, 2026
34 checks passed
@GuillaumeGomez
GuillaumeGomez deleted the deploy-pages branch August 20, 2026 12:32
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 20, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants