In owner invite messages, use crates.io username - #14581
Merged
Merged
Conversation
These are messages that a user sees when they've invited other users to own a crate. Right now, there shouldn't be any confusion because `users.username` should always equal `users.gh_login`, but I've added "Crates.io user" to the message to hopefully clarify for the future when we have crates.io usernames independent of GitHub usernames.
moskirathe
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
i'll update #14213 to resolve the minor conflict this introduces. Should be easy enough to propagate the username type (crates.io or github currently) so that its included in the invite messages.
Turbo87
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are messages that a user sees when they've invited other users to own a crate. Right now, there shouldn't be any confusion because
users.usernameshould always equalusers.gh_login, but I've added "Crates.io user" to the message to hopefully clarify for the future when we have crates.io usernames independent of GitHub usernames.Extracted from #14575; will probably conflict with #14213 a little bit.