fix(project): scope all project prompts to team

[bougyman]

Summary

• issue list --project now resolves the project against only the active team's projects when a team is known (via --team or the active profile), instead of fetching every workspace project. Falls back to all-workspace search when no team context is available.
• project favorite, project unfavorite, and project update now resolve the project against the team's projects exclusively. Team is resolved from the new --team/-t option, the active profile, or an interactive prompt — matching the same resolution order issue create already uses.
• All three project subcommands now accept a --team/-t option (consistent with project list).

Closes EXT-2

Test plan

• mix test — 291/297 pass (6-7 pre-existing git_test.exs env failures, unchanged)
• mix compile — clean
• mix credo — no issues
• favorites_commands_test.exs — updated stubs to handle team-scoped project query (ByTeam format)
• cli_test.exs (project update) — updated stub to handle viewer + team-scoped project query
• New test: --project with --team resolves against team-scoped projects only asserts workspace-wide project query is never made when a team is in scope
• Updated profile tests confirm team-scoped project resolution when profile supplies the team

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[bougyman]

Code Review

Branch: EXT-2-team-scoped-project-prompt
Commits reviewed: 6a4091c (issue list scoping), 18669bc (favorite/unfavorite/update scoping)

Overall Assessment: Approve with minor suggestions

The implementation is correct, well-structured, and consistent with existing patterns in the codebase. The two commits cleanly separate the two scopes of work. Tests are thorough and pass (7 pre-existing git_test.exs environment failures are unchanged).

What looks good

• Consistent team resolution pattern. All three project subcommands (favorite, unfavorite, update) use the same WhatFor.team_for(options.team || Profiles.default_team()) idiom already established by make_da_issue! — no new patterns introduced.
• Clean fallback in issue list. The three-clause resolve_project_id/2 correctly handles: nil project (no-op), team known (team-scoped lookup), team unknown (all-workspace fallback). The guard when is_binary(team_key) is the right way to dispatch.
• Good negative test. The --project with --team test in issue_commands_test.exs raises if the all-workspace projects(first: $first query fires — confirms the team-scoped path is actually taken, not just that results happen to match.
• --team CLI option added consistently to favorite, unfavorite, and update subcommands with identical help text.

Issues found

Minor — Stale docstrings (2 instances)

1. commands.ex line ~91 (HEAD): project_favorite's docstring still says "resolved the same way project update's PROJECT is - against every project in the workspace". The code now resolves against the team's projects. Should read something like "resolved against the active team's projects, prompting if ambiguous. Team is resolved via --team, the active profile, or an interactive prompt" — matching what project_update's docstring already says.

2. commands.ex line ~231 (HEAD): issue_list's docstring still says "--project/-p is resolved the same way Ruby's CLI::Projects#project_for does - against every project in the workspace (Project.all, not team-scoped)". This is no longer accurate when --team is provided or the active profile supplies a team — the code now uses team-scoped resolution in that case. The docstring should mention that --project is resolved against the team's projects when a team is known, falling back to all-workspace when no team context is available.

No critical or major issues found.

Workspace note

The working tree has staged changes that revert the branch's committed work back to the main state. This appears to be a Stokowski workspace artifact and doesn't affect the PR itself, but should not be committed on top of HEAD.

---

Reviewed at run 1, commit 18669bc.

[bougyman]

Code Review Summary (Linear issue EXT-2)

Verdict: Approve with two minor docstring suggestions.

What was reviewed: Both commits on EXT-2-team-scoped-project-prompt — team-scoped project resolution for issue list (6a4091c) and for project favorite/unfavorite/update (18669bc).

Findings:

• Correctness: All paths tested and working. Team-scoped resolution fires when team is known; all-workspace fallback preserved when no team context exists.
• Quality: Consistent with existing WhatFor.team_for pattern. Clean three-clause dispatch in resolve_project_id/2.
• Tests: 289/296 pass (7 pre-existing git_test.exs env failures unchanged). New tests cover the team-scoped path with a negative assertion preventing accidental all-workspace queries.
• Two minor stale docstrings: project_favorite (line ~91) and issue_list (line ~231) still reference "every project in the workspace" but the code now does team-scoped resolution. Non-blocking but worth updating for accuracy.

[bougyman]

Code Review Summary (Linear issue EXT-2)

Verdict: Approve with two minor docstring suggestions.

What was reviewed: Both commits on EXT-2-team-scoped-project-prompt — team-scoped project resolution for issue list (6a4091c) and for project favorite/unfavorite/update (18669bc).

Findings:

• Correctness: All paths tested and working. Team-scoped resolution fires when team is known; all-workspace fallback preserved when no team context exists.
• Quality: Consistent with existing WhatFor.team_for pattern. Clean three-clause dispatch in resolve_project_id/2.
• Tests: 289/296 pass (7 pre-existing git_test.exs env failures unchanged). New tests cover the team-scoped path with a negative assertion preventing accidental all-workspace queries.
• Two minor stale docstrings: project_favorite (line ~91) and issue_list (line ~231) still reference "every project in the workspace" but the code now does team-scoped resolution. Non-blocking but worth updating for accuracy.

Fix the docstrings, they're a contract, too.

[bougyman]

Rework: docstring fixes

Addressed the two stale-docstring nits from code review:

• project_favorite (was commands.ex:90-96): Updated to reflect team-scoped resolution — "resolved against the active team's projects, prompting if ambiguous. Team is resolved via --team, the active profile, or an interactive prompt."
• issue_list (was commands.ex:230-241): Updated to reflect dual-path behavior — team-scoped via projects_by_team when team context is available, falling back to all-workspace Project.all when not.

Also recovered from a botched pre-push rebase that had left all feature changes staged as reversions (the working tree had the old code despite the commits being present). Discarded the staged/unstaged reversions, confirmed the feature commits were intact, then applied and pushed only the docstring fix.

Quality: compile (warnings-as-errors) ✓, format ✓, tests 291/297 (6 pre-existing git_test.exs env failures unchanged) ✓