Accelerate GPU voxel dispatch#66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The previous runtime unconditionally requested a low-power adapter on hybrid systems. The end-to-end benchmark also exposed a 2M-point validation panic from incompatible pooled-buffer usage and substantial command-submission and host-allocation overhead. Meanwhile, later CPU fast paths invalidated the old README crossover claim.
Performance
Isolated Criterion GPU medians after the final batching change:
The current CPU path remains faster through 2M, so Auto now stays on CPU for centroid mode. Explicit GPU and GPU-resident paths remain available. Public receipts intentionally omit the GPU model name.
Validation
cargo test -p spatialrust-gpu --features gpu-wgpu(26 passed)cargo test -p spatialrust-filtering --features filter-voxel-gpu(18 passed)cargo clippy -p spatialrust-gpu --features gpu-wgpu --all-targets -- -D warningscargo clippy -p spatialrust-filtering --features filter-voxel-gpu --all-targets -- -D warningscargo fmt --all --check